Fix ref analysis of self-assignment #75618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
jjonescz
force-pushed
the
75592-CyclicAssignment
branch
from
efc5e21
to
bc4d54e
Compare
jaredpar
requested changes
Oct 24, 2024
RikkiGibson
reviewed
Oct 28, 2024
RikkiGibson
approved these changes
Oct 28, 2024
|
@jaredpar for another look, thanks |
jaredpar
approved these changes
Oct 29, 2024
| @@ -26477,6 +26477,12 @@ static ref S F2(S x2) | |||
|
|
|||
| var comp = CreateCompilation(source, targetFramework: s_targetFrameworkSupportingByRefLikeGenerics); | |||
| comp.VerifyEmitDiagnostics( | |||
| // (12,26): error CS8350: This combination of arguments to 'Program<S>.F1(ref S)' is disallowed because it may expose variables referenced by parameter 'x1' outside of their declaration scope | |||
There was a problem hiding this comment.
Can we add a variation of this test where the signature of F1 is
static ref S F1(ref S x1)
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75592.