Bind lambda in yield return despite errors
#75660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
AlekseyTs
reviewed
Oct 29, 2024
|
|
||
| // NOTE: it's possible that more than one of these conditions is satisfied and that | ||
| // we won't report the syntactically innermost. However, dev11 appears to check | ||
| // them in this order, regardless of syntactic nesting (StatementBinder::bindYield). | ||
| if (this.Flags.Includes(BinderFlags.InFinallyBlock)) | ||
| { | ||
| Error(diagnostics, ErrorCode.ERR_BadYieldInFinally, node.YieldKeyword); | ||
| hasErrors = true; |
There was a problem hiding this comment.
There was a problem hiding this comment.
I woke up this morning with the same thought, but you'd already reviewed. Thanks
AlekseyTs
reviewed
Oct 29, 2024
| } | ||
|
|
||
| CheckRequiredLangVersionForIteratorMethods(node, diagnostics); | ||
|
|
||
| if (argument != null) |
AlekseyTs
reviewed
Oct 29, 2024
AlekseyTs
reviewed
Oct 29, 2024
| """; | ||
| var comp = CreateCompilation(src, targetFramework: TargetFramework.Net80); | ||
| comp.VerifyDiagnostics( | ||
| // (7,63): warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. |
|
Done with review pass (commit 3) |
|
@dotnet/roslyn-compiler for second review. Thanks |
RikkiGibson
approved these changes
Oct 30, 2024
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68027
The problem was that
BindYieldReturnStatementgave up too easily on trying to convert the lambda. Without conversion, the lambda state didn't account for the target delegate type, which provides the parameter types for the lambda. So the lookup result for identifiers(which finds a candidate for type in local declarations await) lacked a type.In fixing this, I noticed that the binding diagnostics for the
yield returnand thereturnscenarios were different.The
ERR_BadSKknownandERR_IllegalStatementbinding errors were now reported in theyield returnscenario, but not in thereturnscenario.In
BindYieldReturn, we useGenerateConversionForAssignmentwhich collects the conversion diagnostics fromGenerateImplicitConversionErrorunlessexpression.HasAnyErrors && expression.Kind != BoundKind.UnboundLambda.In
BindReturn, we useCreateReturnConversion, which skipped reporting fromGenerateImplicitConversionErrorifargument.HasAnyErrors.So I made an adjustment to the
returnbinding logic to also report the diagnostics from converting/binding the lambda (BoundKind.UnboundLambda).