Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flow of CompilerGeneratedFilesOutputPath from CPS #75674

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Fix flow of CompilerGeneratedFilesOutputPath from CPS #75674

merged 4 commits into from
Nov 1, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Oct 30, 2024 •
edited
Loading

Fixes #75680

@tmat tmat requested a review from a team as a code owner October 30, 2024 01:44
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 30, 2024
@arunchndr
Copy link
Member

@akhera99 fyi

@drewnoakes
Copy link
Member

Linking to #75311

@jjonescz
Copy link
Member

jjonescz commented Nov 1, 2024

Fixes #75680?

@tmat tmat requested a review from a team as a code owner November 1, 2024 15:20
tmat and others added 2 commits November 1, 2024 11:52
@tmat @chsienki
Update src/VisualStudio/CSharp/Test/ProjectSystemShim/CPS/CSharpCompi…
82a6808 
…lerOptionsTests.cs

Co-authored-by: Chris Sienkiewicz <chsienki@microsoft.com>
@tmat @chsienki
Update src/VisualStudio/CSharp/Test/ProjectSystemShim/CPS/AdditionalP…
4b30d25 
…ropertiesTests.cs

Co-authored-by: Chris Sienkiewicz <chsienki@microsoft.com>
@arunchndr arunchndr merged commit be03640 into dotnet:release/dev17.13 Nov 1, 2024
13 of 28 checks passed
@tmat tmat deleted the FixCompilerGeneratedFilesOutputPath branch November 1, 2024 22:35
@drewnoakes drewnoakes mentioned this pull request Nov 3, 2024
Merged
This was referenced Nov 7, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chsienki chsienki chsienki approved these changes

@drewnoakes drewnoakes drewnoakes left review comments

@arunchndr arunchndr arunchndr approved these changes

@ToddGrun ToddGrun ToddGrun approved these changes

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tmat @arunchndr @drewnoakes @jjonescz @jasonmalinowski @ToddGrun @chsienki