Bail out of on-the-fly-docs for razor documents #75818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
genlu
reviewed
Nov 8, 2024
| @@ -151,6 +152,10 @@ protected override NullableFlowState GetNullabilityAnalysis(SemanticModel semant | |||
| { | |||
| return null; | |||
| } | |||
| if (document.IsRazorDocument()) | |||
There was a problem hiding this comment.
don't use the extension method from EA.Razor.Api namespace, use the one under Microsoft.CodeAnalysis.Host directly instead
https://github.com/dotnet/roslyn/blob/main/src/Workspaces/Core/Portable/Workspace/Host/DocumentService/Extensions.cs
3 tasks
genlu
approved these changes
Nov 8, 2024
| @@ -151,6 +152,10 @@ protected override NullableFlowState GetNullabilityAnalysis(SemanticModel semant | |||
| { | |||
| return null; | |||
| } | |||
| if (document.IsRazorDocument()) | |||
There was a problem hiding this comment.
this really needed a comment explaning wy we would nto get tehse results in razor.
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #75106
Razor doesn't seem to support the IViewElementFactory, so when the element was getting added to quick-info, it was never getting converted into UI.