Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always sync text changes and active doc info to remote workspace #75864

Merged
merged 22 commits into from
Nov 13, 2024
Merged

Always sync text changes and active doc info to remote workspace #75864

merged 22 commits into from
Nov 13, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Nov 12, 2024 •
edited
Loading

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 12, 2024 00:37
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 12, 2024
@ToddGrun
Copy link
Contributor

ToddGrun commented Nov 12, 2024 •
edited
Loading

Build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10541569&view=results

Hmm, that didn't have the desired effect. Lots of TagSpan[] allocations in the test insertion. It seems suspicious that it's around a SegmentedList usage and I changed that data structure since the last roslyn insertion. But, the baseline had no allocations for that type, so it might be that a codepath that is enabled by this PR.

It's also unfortunate that the latest Roslyn insertion PR which includes the SegmentedList changes failed (https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/VS/pullrequest/591614)

ToddGrun
ToddGrun reviewed Nov 12, 2024
View reviewed changes
src/EditorFeatures/Core/Remote/SolutionChecksumUpdater.cs Outdated
if (_isSynchronizeWorkspacePaused)
return;
}

_synchronizeWorkspaceQueue.AddWork();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_synchronizeWorkspaceQueue

This didn't change so I'm sure it's fine, but the Resume/Pause methods execute the calls onto the _synchronizeWorkspaceQueue from within the lock.

ToddGrun
ToddGrun approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ToddGrun
Copy link
Contributor

I get an error in ServiceHubServicesTests compiling these changes locally

CyrusNajmabadi and others added 4 commits November 12, 2024 14:12
@CyrusNajmabadi
Fix
d349374
@CyrusNajmabadi
Fix
eb999ce
@CyrusNajmabadi @ToddGrun
Update src/Workspaces/Core/Portable/Workspace/Solution/Solution_Seman…
c622f13 
…ticModelCaching.cs

Co-authored-by: Todd Grunke <toddgrun@microsoft.com>
@CyrusNajmabadi
Add test
78246be
@CyrusNajmabadi
Copy link
Member Author

I get an error in ServiceHubServicesTests compiling these changes locally

Have you tried turning it off and on again?

@CyrusNajmabadi CyrusNajmabadi merged commit 42613df into dotnet:main Nov 13, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the syncWork branch November 13, 2024 17:17
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 13, 2024
This was referenced Nov 15, 2024
Closed
Closed
Closed
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @ToddGrun @jjonescz