Relax RCS1047 if the return value is a ValueTask

[gumbarros]

Product and Version Used:
Latest
Steps to Reproduce:

Actual Behavior:

return await fluidTemplate.RenderAsync(context); //RCS1047

Expected Behavior:

return await fluidTemplate.RenderAsync(context); //No RCS1047

[josefpihrt]

Could you explain why do you think that method should not be treated as asynchronous when it return ValueTask<T>? ValueTask<T> is basically the same as Task<T> just with less allocations.

[gumbarros]

Could you explain why do you think that method should not be treated as asynchronous when it return ValueTask<T>? ValueTask<T> is basically the same as Task<T> just with less allocations.

It's actually the opposite, the problem is that RCS1047 doesn't understand ValueTask as async and tells you to remove the async suffix.

[josefpihrt]

RCS1047 should be able to detect ValueTask:

https://github.com/dotnet/roslynator/blob/main/src/Core/SymbolUtility.cs#L641-L642

Could you post a code snippet that reproduces the bug? Which version are you on?