[main] Update dependencies from dotnet/roslyn-analyzers (#85518)

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230427.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.3.5-beta1.23225.2 -> To Version 3.3.5-beta1.23227.3 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230501.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.3.5-beta1.23225.2 -> To Version 3.3.5-beta1.23251.1 * Fix another CA1854 warning --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
dotnet · May 3, 2023 · 442141d · 442141d
1 parent 364c125
commit 442141d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
@@ -328,13 +328,13 @@
       <Uri>https://github.com/dotnet/roslyn</Uri>
       <Sha>56393223b78d294bccec3101e79dc03e1b3cb683</Sha>
     </Dependency>
-    <Dependency Name="Microsoft.CodeAnalysis.Analyzers" Version="3.3.5-beta1.23225.2">
+    <Dependency Name="Microsoft.CodeAnalysis.Analyzers" Version="3.3.5-beta1.23251.1">
       <Uri>https://github.com/dotnet/roslyn-analyzers</Uri>
-      <Sha>429d834b45bfa439b8ea3692cc8bb3d1805872f5</Sha>
+      <Sha>31e5d2773251838851d273edba1babcf60321f24</Sha>
     </Dependency>
-    <Dependency Name="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0-preview.23225.2">
+    <Dependency Name="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0-preview.23251.1">
       <Uri>https://github.com/dotnet/roslyn-analyzers</Uri>
-      <Sha>429d834b45bfa439b8ea3692cc8bb3d1805872f5</Sha>
+      <Sha>31e5d2773251838851d273edba1babcf60321f24</Sha>
     </Dependency>
     <Dependency Name="Microsoft.DotNet.ApiCompat.Task" Version="8.0.100-preview.2.23107.1">
       <Uri>https://github.com/dotnet/sdk</Uri>

diff --git a/eng/Versions.props b/eng/Versions.props
@@ -32,8 +32,8 @@
   </ItemGroup>
   <PropertyGroup>
     <!-- dotnet/roslyn-analyzers dependencies -->
-    <MicrosoftCodeAnalysisAnalyzersVersion>3.3.5-beta1.23225.2</MicrosoftCodeAnalysisAnalyzersVersion>
-    <MicrosoftCodeAnalysisNetAnalyzersVersion>8.0.0-preview.23225.2</MicrosoftCodeAnalysisNetAnalyzersVersion>
+    <MicrosoftCodeAnalysisAnalyzersVersion>3.3.5-beta1.23251.1</MicrosoftCodeAnalysisAnalyzersVersion>
+    <MicrosoftCodeAnalysisNetAnalyzersVersion>8.0.0-preview.23251.1</MicrosoftCodeAnalysisNetAnalyzersVersion>
     <!-- dotnet/roslyn dependencies -->
     <!--
       These versions should not be used by any project that contributes to the design-time experience in VS, such as an analyzer, code-fix, or generator assembly.

diff --git a/...curity.Cryptography/src/System/Security/Cryptography/X509Certificates/ChainPal.Android.cs b/...curity.Cryptography/src/System/Security/Cryptography/X509Certificates/ChainPal.Android.cs
@@ -342,12 +342,13 @@ private static Dictionary<int, List<X509ChainStatus>> GetStatusByIndex(SafeX509C
                     X509ChainStatus chainStatus = ValidationErrorToChainStatus(error);
                     Marshal.FreeHGlobal(error.Message);
 
-                    if (!statusByIndex.ContainsKey(error.Index))
+                    if (!statusByIndex.TryGetValue(error.Index, out List<X509ChainStatus>? value))
                     {
-                        statusByIndex.Add(error.Index, new List<X509ChainStatus>());
+                        value = new List<X509ChainStatus>();
+                        statusByIndex.Add(error.Index, value);
                     }
 
-                    statusByIndex[error.Index].Add(chainStatus);
+                    value.Add(chainStatus);
                 }
 
                 return statusByIndex;