From 8ad84e88d86fb7845187ae0aa17be48ed1a46c97 Mon Sep 17 00:00:00 2001 From: Simon Rozsival Date: Thu, 11 Nov 2021 15:10:34 +0100 Subject: [PATCH] [Mono] Skip flaky android tests (#61460) There are connectivity issues on some physical Android devices. We should disable the affected tests until the issue isn't resolved. Ref #61343 --- .../tests/FunctionalTests/UnixPingUtilityTests.cs | 1 + .../System.Net.Sockets/tests/FunctionalTests/SendTo.cs | 2 ++ .../tests/FunctionalTests/SocketOptionNameTest.cs | 2 ++ .../System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs | 4 ++++ 4 files changed, 9 insertions(+) diff --git a/src/libraries/System.Net.Ping/tests/FunctionalTests/UnixPingUtilityTests.cs b/src/libraries/System.Net.Ping/tests/FunctionalTests/UnixPingUtilityTests.cs index b34f45bdd881f..b16401f2b5e2c 100644 --- a/src/libraries/System.Net.Ping/tests/FunctionalTests/UnixPingUtilityTests.cs +++ b/src/libraries/System.Net.Ping/tests/FunctionalTests/UnixPingUtilityTests.cs @@ -26,6 +26,7 @@ public class UnixPingUtilityTests [InlineData(1000)] [InlineData(1500)] [PlatformSpecific(TestPlatforms.AnyUnix)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public static void TimeoutIsRespected(int timeout) { Process p = ConstructPingProcess(IPAddress.Parse(TestSettings.UnreachableAddress), 50, timeout); diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendTo.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendTo.cs index 70205f8033cc4..433846482c858 100644 --- a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendTo.cs +++ b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendTo.cs @@ -64,6 +64,7 @@ public async Task NullEndpoint_Throws_ArgumentException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public async Task Datagram_UDP_ShouldImplicitlyBindLocalEndpoint() { using var socket = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp); @@ -84,6 +85,7 @@ public async Task Datagram_UDP_ShouldImplicitlyBindLocalEndpoint() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public async Task Datagram_UDP_AccessDenied_Throws_DoesNotBind() { IPEndPoint invalidEndpoint = new IPEndPoint(IPAddress.Broadcast, 1234); diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs index 5073f60c3e6a1..5879de156120c 100644 --- a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs +++ b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs @@ -51,6 +51,7 @@ public void ReuseUnicastPort_CreateSocketSetOption() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public void MulticastOption_CreateSocketSetGetOption_GroupAndInterfaceIndex_SetSucceeds_GetThrows() { int interfaceIndex = 0; @@ -65,6 +66,7 @@ public void MulticastOption_CreateSocketSetGetOption_GroupAndInterfaceIndex_SetS } [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoNorServerCore))] // Skip on Nano: https://github.com/dotnet/runtime/issues/26286 + [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public async Task MulticastInterface_Set_AnyInterface_Succeeds() { // On all platforms, index 0 means "any interface" diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs index 66f69e1ce70da..cc16a77f1997d 100644 --- a/src/libraries/System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs +++ b/src/libraries/System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs @@ -439,6 +439,7 @@ public void Connect_InvalidArguments_Throws() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public async Task ConnectAsync_StringHost_Success() { using (var c = new UdpClient()) @@ -448,6 +449,7 @@ public async Task ConnectAsync_StringHost_Success() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public async Task ConnectAsync_IPAddressHost_Success() { using (var c = new UdpClient()) @@ -457,6 +459,7 @@ public async Task ConnectAsync_IPAddressHost_Success() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public void Connect_StringHost_Success() { using (var c = new UdpClient()) @@ -466,6 +469,7 @@ public void Connect_StringHost_Success() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public void Connect_IPAddressHost_Success() { using (var c = new UdpClient())