From d7138f3badcdd528e05c0a93c41f2b56ea310edf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Rylek?= Date: Wed, 23 Aug 2023 00:02:12 +0200 Subject: [PATCH] Slightly reduce the Depth3Test that often times out on Linux (#90777) * Slightly reduce the Depth3Test that often times out on Linux This is one of the regression tests I introduced as part of implementing protection against infinite generic recursion in Crossgen2. Turns out that on the relatively slow Helix Linux VMs the test often times out due to compilation time exceeding 10 minutes. I propose slightly trimming down the test so that it uses less time in Helix. Thanks Tomas * Remove issues.targets exclusion for the Depth3Test --- src/tests/issues.targets | 3 --- src/tests/readytorun/GenericCycleDetection/Depth3Test.cs | 2 -- 2 files changed, 5 deletions(-) diff --git a/src/tests/issues.targets b/src/tests/issues.targets index 221ed02229eb4..05b995cd0d6b0 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -72,9 +72,6 @@ https://github.com/dotnet/runtime/issues/89585 - - https://github.com/dotnet/runtime/issues/88586 - diff --git a/src/tests/readytorun/GenericCycleDetection/Depth3Test.cs b/src/tests/readytorun/GenericCycleDetection/Depth3Test.cs index 2edaef57d2681..565079d5d269c 100644 --- a/src/tests/readytorun/GenericCycleDetection/Depth3Test.cs +++ b/src/tests/readytorun/GenericCycleDetection/Depth3Test.cs @@ -23,7 +23,6 @@ public static long TypeNestedFactorial(int count) if (result < count) result = Depth1>.TypeNestedFactorial(count - 1); if (result < count) result = Depth1>.TypeNestedFactorial(count - 1); if (result < count) result = Depth1>.TypeNestedFactorial(count - 1); - if (result < count) result = Depth1>.TypeNestedFactorial(count - 1); return count * result; } } @@ -31,7 +30,6 @@ public static long TypeNestedFactorial(int count) private struct Depth2 {} private struct Depth3 {} private struct Depth4 {} - private struct Depth5 {} [Fact] public static int DepthTest()