Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/arm64: 1 Regression on 6/25/2024 5:29:23 PM #104107

Closed
performanceautofiler bot opened this issue Jun 27, 2024 · 5 comments
Closed

[Perf] Linux/arm64: 1 Regression on 6/25/2024 5:29:23 PM #104107

performanceautofiler bot opened this issue Jun 27, 2024 · 5 comments
Labels
area-System.Net.Http tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture arm64
OS ubuntu 22.04
Queue AmpereUbuntu
Baseline a54d9e9b991c9059f85150f2e69b6507f103b322
Compare b8b3bf2ff50c5b63cc27db0b250ac29d5a40c5ad
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Net.Primitives.Tests.CredentialCacheTests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
334.76 ns 405.38 ns 1.21 0.02 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Net.Primitives.Tests.CredentialCacheTests*'

System.Net.Primitives.Tests.CredentialCacheTests.GetCredential_Uri(uriString: "http://notfound", uriCount: 10)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-arm64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Jun 27, 2024
@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues Jun 27, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 27, 2024
@DrewScoggins DrewScoggins added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Jun 27, 2024
@DrewScoggins
Copy link
Member

The change to fix the previous regression seems to have caused a new one here. Also the second test in this issue did not seem to fully come back from this fix, #102281.

Change - #103714

@stephentoub
Copy link
Member

cc: @rzikm

@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 1, 2024
@matouskozak
Copy link
Member

matouskozak commented Jul 2, 2024

Related Mono arm64 AOT-llvm regression: #104302
CoreCLR Windows x64 - dotnet/perf-autofiling-issues#37375, dotnet/perf-autofiling-issues#37366
CoreCLR Linux x64 - dotnet/perf-autofiling-issues#37352

@MihaZupan
Copy link
Member

All the regressions are for the (uriString: "http://notfound", uriCount: 10) case.
@rzikm from #103714 (comment) it sounds like that was by-design and we don't care?

@MihaZupan MihaZupan removed arch-arm64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime labels Jul 2, 2024
@rzikm
Copy link
Member

rzikm commented Jul 3, 2024

Correct, the regressed scenario is for case when the hostname is not in the cache at all, which will be rare I think. A sacrifice was made to make the other scenarios faster.

@rzikm rzikm closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2024
@rzikm rzikm removed their assignment Jul 3, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Jul 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
@karelz karelz added this to the 9.0.0 milestone Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

8 participants