Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DomainAssembly concept #104590

Open
elinor-fung opened this issue Jul 9, 2024 · 1 comment · May be fixed by #108618
Open

Remove DomainAssembly concept #104590

elinor-fung opened this issue Jul 9, 2024 · 1 comment · May be fixed by #108618
Labels
area-AssemblyLoader-coreclr in-pr There is an active PR which will close this issue when it is merged
Milestone

Comments

@elinor-fung
Copy link
Member

elinor-fung commented Jul 9, 2024

DomainAssembly represented an assembly loaded (or being loaded) into a particular app domain - that is, there was a unique DomainAssembly per assembly per app domain. In our one app domain world, DomainAssembly versus Assembly is a confusing abstraction. We should move things off of DomainAssembly and eventually remove it.

Some things it currently handles:

  • Exposed managed object for Assembly and Module - should be able to move to Assembly/Module
  • Associated with AssemblyObject - can probably become Assembly
  • FileLoadLevel, incremental loading based on level, and associated tracking/checks - maybe this - just load tracking - is what it becomes (renamed) or maybe collapse into Assembly
  • Determining DebuggerAssemblyControlFlags for the assembly/module
  • Used as main representation of a module in internal debug interfaces
  • Tracking of collectible assemblies in the same ALC
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 9, 2024
Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-AssemblyLoader-coreclr in-pr There is an active PR which will close this issue when it is merged
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant