-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Apple] Microsoft-Diagnostics-DiagnosticSource EventSource not terminated properly #104881
Comments
Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger |
Tagging subscribers to 'os-tvos': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger |
Tagging subscribers to 'os-maccatalyst': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger |
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti |
Could it be related to #104847 @mikelle-rogers ? Even though the PR looks to be CoreCLR specific, it's the only diagnostics-related PR in the range. |
I will look into it |
As a result of this only reproducing on one test run, we should wait and see if it happens again. |
Thank you for looking into it Mikelle! Based on my investigation it does reproduce on multiple runs, e.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=740629 and https://dev.azure.com/dnceng-public/public/_build/results?buildId=740849. I'm unsure why the Build Analysis matching doesn't show more hits at the moment. |
It has been tested and verified that the commit causing the issue is ee5770d. |
Thank you Mikelle for the investigation. @antonfirsov do you know why #103922 could cause these failures? |
@antonfirsov would you mind investigating the regression caused by #103922? |
#103922 didn't touch any code in A speculative fix idea is to add runtime/src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestUtilities.cs Lines 25 to 41 in 2c99cc5
Otherwise, I lack access to iOS devices and don't have a good understanding of the test+product code in question, so I don't consider myself a good candidate for a deeper investigation. |
Build Information
Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=740287
Build error leg or test failing:
System.Diagnostics.Tracing.Tests
Affected CI:
[tvos/ios]simulator-x64 Release AllSubsets_Mono
,maccatalyst-[arm64/x64] Release AllSubsets_Mono
(runtime-extra-platforms
)Range of commits: ac0eeb0...74af205
Stack trace example:
Error Message
Fill the error message using step by step known issues guidance.
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=740287
Error message validated:
[[FAIL] BasicEventSourceTests.TestsManifestNegative.Test_GenerateManifest_InvalidEventSources
]Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 7/15/2024 7:18:48 AM UTC
Report
Summary
The text was updated successfully, but these errors were encountered: