Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctor_Dispose_HandleClosedIfOwnsHandle failed in CI #105379

Closed
stephentoub opened this issue Jul 24, 2024 · 3 comments · Fixed by #105448
Closed

Ctor_Dispose_HandleClosedIfOwnsHandle failed in CI #105379

stephentoub opened this issue Jul 24, 2024 · 3 comments · Fixed by #105448
Labels
area-System.Net blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab test-bug Problem in test source code (most likely)
Milestone

Comments

@stephentoub
Copy link
Member

stephentoub commented Jul 24, 2024

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=752819
Build error leg or test failing: System.Net.Sockets.Tests.WorkItemExecution
Pull request: #105344

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": ["Ctor_Dispose_HandleClosedIfOwnsHandle", "Values differ"],
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}
Windows.Nano.1809.Amd64.Open

    System.Net.Sockets.Tests.CreateSocket.Ctor_Dispose_HandleClosedIfOwnsHandle(ownsHandle: True) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: False
      Actual:   True
      Stack Trace:
        /_/src/libraries/System.Net.Sockets/tests/FunctionalTests/CreateSocketTests.cs(709,0): at System.Net.Sockets.Tests.CreateSocket.Ctor_Dispose_HandleClosedIfOwnsHandle(Boolean ownsHandle)
           at InvokeStub_CreateSocket.Ctor_Dispose_HandleClosedIfOwnsHandle(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
Process terminated. Assertion failed.
ReleaseHandle failed. handle:8684
   at System.Net.Sockets.SafeSocketHandle.CloseHandle(Boolean abortive, Boolean canceledOperations) in /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/SafeSocketHandle.cs:line 134
   at System.Net.Sockets.SafeSocketHandle.ReleaseHandle() in /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/SafeSocketHandle.cs:line 86
   at System.Runtime.InteropServices.SafeHandle.InternalRelease(Boolean disposeOrFinalizeOperation) in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/SafeHandle.cs:line 266
   at System.Runtime.InteropServices.SafeHandle.Dispose() in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/SafeHandle.cs:line 108
   at System.Net.Sockets.Socket.Dispose(Boolean disposing) in /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs:line 3259
   at System.Net.Sockets.Socket.Finalize() in /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs:line 3381
   at System.GC.RunFinalizers() in /_/src/coreclr/System.Private.CoreLib/src/System/GC.CoreCLR.cs:line 320

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=752819
Error message validated: [Ctor_Dispose_HandleClosedIfOwnsHandle Values differ]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 7/24/2024 3:50:08 AM UTC

Report

Build Definition Test Pull Request
752819 dotnet/runtime System.Net.Sockets.Tests.WorkItemExecution #105344

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 1 1
@stephentoub stephentoub added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Jul 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 24, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Jul 24, 2024

This is bad test. The test is trying to close a random handle and expected it to fail. It won't work if some other thread opened a handle that happens to have the same value.

@jkotas jkotas added the test-bug Problem in test source code (most likely) label Jul 24, 2024
@wfurt wfurt removed the untriaged New issue has not been triaged by the area owner label Jul 24, 2024
@wfurt wfurt added this to the 9.0.0 milestone Jul 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants