-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building System.Runtime.InteropServices.JavaScript.Tests.csproj (all TFMs) fails locally #106476
Comments
Tagging subscribers to 'arch-wasm': @lewing |
That assembly only makes sense for Browser target. Is that not enough ? We could make all |
|
For execution, yes but managed libraries must be buildable on all OSs. Maybe the linker settings are wrong? Or to rephrase, why does the linker not emit errors when building with a TargetOS=browser? |
I tested locally. If I remove
it will pass just fine on non-browser. I don't know why trimming doesn't complain for browser. |
@pavelsavara can you please send me a binlog when you successfully build that project on browser (offline via Teams)? I'm not sure if I can find that in a CI run somewhere. I would like to compare the linker settings on non browser vs browser. |
This needs to be fixed for #106474
@pavelsavara
The text was updated successfully, but these errors were encountered: