Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wasm] Support for the mono log profiler for memory profiling #107312

Closed
jeromelaban opened this issue Sep 3, 2024 · 2 comments · Fixed by #107434
Closed

[Wasm] Support for the mono log profiler for memory profiling #107312

jeromelaban opened this issue Sep 3, 2024 · 2 comments · Fixed by #107434
Labels
arch-wasm WebAssembly architecture area-Build-mono in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Milestone

Comments

@jeromelaban
Copy link
Contributor

The mono runtime provides a log profiler, which can generate mlpd files, which can be parsed by the Xamarin Profiler.

This feature is not enabled in the current main, and considering that #105713 may not make its way into .NET 9, being able to profile the memory of wasm apps is still a critical scenario.

If this helps, I have a net8 patch that enabled it for Uno's custom runtime, which can certainly be updated for net9 and the wasmhost builds.

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Sep 3, 2024
@jeromelaban jeromelaban changed the title [Wasm] Support for the mono log profiler [Wasm] Support for the mono log profiler for memory profiling Sep 3, 2024
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Sep 4, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara added this to the 9.0.0 milestone Sep 4, 2024
@pavelsavara pavelsavara removed the untriaged New issue has not been triaged by the area owner label Sep 4, 2024
@pavelsavara
Copy link
Member

Looking at the patch, I'm thinking this will add few KB of the native code, do you know how much ?

I wonder if we could move that to be linked only when enabled by some msbuild property in the linking phase of emcc/workload re-link. Together with the other 2 profilers.

cc @maraf

@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Sep 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants