Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Windows/x64: 1 Regression in System.Text.RegularExpressions.Tests.Perf_Regex_Industry_BoostDocs_Simple #109735

Closed
performanceautofiler bot opened this issue Nov 12, 2024 · 2 comments · Fixed by #109737
Closed

[Perf] Windows/x64: 1 Regression in System.Text.RegularExpressions.Tests.Perf_Regex_Industry_BoostDocs_Simple #109735

performanceautofiler bot opened this issue Nov 12, 2024 · 2 comments · Fixed by #109737
Assignees
@MihaZupan
Labels
arch-x64 area-System.Text.RegularExpressions in-pr There is an active PR which will close this issue when it is merged os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone
10.0.0

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS Windows 10.0.22631
Queue ViperWindows
Baseline f697b537030934bae2e1d98306e2439168f01365
Compare 443f63dfaf82306f178badf43763f208e859ff20
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Text.RegularExpressions.Tests.Perf_Regex_Industry_BoostDocs_Simple

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
28.02 ns 29.90 ns 1.07 0.03 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.RegularExpressions.Tests.Perf_Regex_Industry_BoostDocs_Simple*'

System.Text.RegularExpressions.Tests.Perf_Regex_Industry_BoostDocs_Simple.IsMatch(Id: 0, Options: Compiled)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added arch-x64 os-windows runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Nov 12, 2024
@performanceautofiler performanceautofiler bot mentioned this issue Nov 12, 2024
Closed
@LoopedBard3 LoopedBard3 transferred this issue from dotnet/perf-autofiling-issues Nov 12, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

@LoopedBard3
Copy link
Member

Likely caused by: #108368. FYI @MihaZupan.

Commit range: ffcef3d...809d3d2

@LoopedBard3 LoopedBard3 added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Nov 12, 2024
@LoopedBard3 LoopedBard3 changed the title [Perf] Windows/x64: 1 Regression on 11/8/2024 9:06:16 AM [Perf] Windows/x64: 1 Regression in System.Text.RegularExpressions.Tests.Perf_Regex_Industry_BoostDocs_Simple Nov 12, 2024
@MihaZupan MihaZupan self-assigned this Nov 12, 2024
@MihaZupan MihaZupan added this to the 10.0.0 milestone Nov 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Nov 12, 2024
@MihaZupan MihaZupan mentioned this issue Nov 12, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Nov 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MihaZupan MihaZupan

Labels
arch-x64 area-System.Text.RegularExpressions in-pr There is an active PR which will close this issue when it is merged os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Add AggressiveInlining to type checks in SearchValues<string> MihaZupan/runtime
2 participants
@LoopedBard3 @MihaZupan