Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomizedallocationsampling tests are failing on nativeaot #109828

Closed
jkotas opened this issue Nov 14, 2024 · 2 comments · Fixed by #109853
Closed

randomizedallocationsampling tests are failing on nativeaot #109828

jkotas opened this issue Nov 14, 2024 · 2 comments · Fixed by #109853
Assignees
Labels
area-Diagnostics-coreclr blocking-clean-ci-optional Blocking optional rolling runs in-pr There is an active PR which will close this issue when it is merged
Milestone

Comments

@jkotas
Copy link
Member

jkotas commented Nov 14, 2024

To reproduce in CI: Run /azp run runtime-nativeaot-outerloop

Log https://dev.azure.com/dnceng-public/public/_build/results?buildId=869748&view=ms.vss-test-web.build-test-results-tab&runId=22659190&resultId=115517&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

  0.0s: ==TEST STARTING==
  0.0s: Started sending sentinel events...
  0.0s: Connecting to EventPipe...
  0.0s: Creating EventPipeEventSource...
  0.0s: EventPipeEventSource created
  0.0s: Dynamic.All callback registered
  0.0s: Running optional trace validator
  0.0s: Finished running optional trace validator
  0.0s: Starting stream processing...
  0.1s: Saw new provider 'Microsoft-Windows-DotNETRuntime'
  0.1s: Saw sentinel event
  0.1s: Stopped sending sentinel events
  0.1s: Starting event generating action...
  0.4s: Allocated 400000 instances...
  0.7s: Allocated 800000 instances...
  1.2s: Allocated 1200000 instances...
  1.5s: Allocated 1600000 instances...
  2.3s: 2000000 instances allocated
  2.3s: Stopping event generating action
  2.3s: Sending StopTracing command...
  2.4s: Saw new provider 'Microsoft-DotNETCore-EventPipe'
  2.4s: Stopping stream processing
  2.4s: Dropped 0 events
  2.4s: Finished StopTracing command
  2.4s: Reader task finished
  2.4s: Validating optional callback...
  2.4s: AllocationSampled counts validation
  2.4s: Nb events: 2681
  2.4s: Nb object128: 0
  2.4s: ==TEST FINISHED: FAILED!==
Xunit.Sdk.EqualException: Assert.Equal() Failure: Values differ
Expected: 100
Actual:   -1
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Nov 14, 2024
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member Author

jkotas commented Nov 14, 2024

cc @noahfalk

@tommcdon tommcdon added this to the 10.0.0 milestone Nov 14, 2024
@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Nov 14, 2024
noahfalk added a commit to noahfalk/runtime that referenced this issue Nov 15, 2024
Fixes dotnet#109828
This test hadn't been updated to account for NativeAOT's lack of type names in the new randomized sampling allocation events.
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Nov 15, 2024
noahfalk added a commit to noahfalk/runtime that referenced this issue Nov 15, 2024
Fixes dotnet#109828
This test hadn't been updated to account for NativeAOT's lack of type names in the new randomized sampling allocation events.
noahfalk added a commit to noahfalk/runtime that referenced this issue Nov 16, 2024
Fixes dotnet#109828
This test hadn't been updated to account for NativeAOT's lack of type names in the new randomized sampling allocation events.
noahfalk added a commit to noahfalk/runtime that referenced this issue Nov 17, 2024
Fixes dotnet#109828
This test hadn't been updated to account for NativeAOT's lack of type names in the new randomized sampling allocation events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Diagnostics-coreclr blocking-clean-ci-optional Blocking optional rolling runs in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants