Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS/tvOS/MacCatalyst] String comparer for sorting numeric strings logically #109999

Open
PranavSenthilnathan opened this issue Nov 20, 2024 · 4 comments
Assignees
Labels
Milestone

Comments

@PranavSenthilnathan
Copy link
Member

CompareOptions.NumericOrdering should be supported in Apple platforms. See #13979 for the approved API and discussion. PR #109861 adds the member CompareOptions.NumericOrdering but does not provide a conforming implementation for Apple platforms. The remaining work is to update the platform abstraction layer to support this.

PAL change would be to recognize the dotnet CompareOptions and convert it to the NSString.CompareOptions here

This is the numeric compare option documentation for reference: NSString.CompareOptions API

PR #109861 throws PlatformNotSupportedException when this option is used and skips tests that used this option, so when this is implemented, those guards can be removed.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 20, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Nov 20, 2024
@PranavSenthilnathan PranavSenthilnathan added area-System.Globalization and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 20, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Tagging subscribers to 'os-tvos': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@tarekgh tarekgh added the os-maccatalyst MacCatalyst OS label Nov 20, 2024
Copy link
Contributor

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Tagging subscribers to 'os-maccatalyst': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@tarekgh tarekgh added the untriaged New issue has not been triaged by the area owner label Nov 20, 2024
@matouskozak matouskozak removed the untriaged New issue has not been triaged by the area owner label Nov 20, 2024
@matouskozak matouskozak added this to the 10.0.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants