Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore using EventSource in front of ILogger #12750

Open
noahfalk opened this issue May 24, 2019 · 1 comment
Open

Explore using EventSource in front of ILogger #12750

noahfalk opened this issue May 24, 2019 · 1 comment

Comments

@noahfalk
Copy link
Member

Today there is some friction using ILogger from .Net libraries. Different library authors may have different reasons but some common examples would be ILogger isn't shipped as part of the BCL, or that they don't want to create requirements that the library user pass in an ILogger instance. There are different ideas on how to get deal with this, one of them being use EventSource from the library and let the app developer bridge it to ILogger if that is what they are using.

This issue tracks exploring what that could look like, cataloging potential issues and solutions to those issues. There is some related discussion that already happened in #12730 - in particular the desire to transmit Exception objects without serializing them.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@reyang
Copy link

reyang commented Nov 23, 2021

In addition, folks using EventSource might want to get the correlation with Activity. This could also be done by updating the ETW correlation GUID during Activity creation/destruction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants