Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crossgen2] Make sure constructing a delegate from a function pointer to an external method works. #13395

Closed
cshung opened this issue Aug 27, 2019 · 1 comment
Closed

[crossgen2] Make sure constructing a delegate from a function pointer to an external method works. #13395

cshung opened this issue Aug 27, 2019 · 1 comment
Assignees
@janvorli
Labels
area-crossgen2-coreclr
Milestone
5.0.0

Comments

@cshung
Copy link
Member

cshung commented Aug 27, 2019

In dotnet/corert#7724, I have made a change to ensure we have a PrecodeMethodImport for local methods, we should probably do the same for external methods to make sure the same scenario works there.
@MichalStrehovsky MichalStrehovsky transferred this issue from dotnet/corert Sep 10, 2019
@cshung cshung changed the title [CPAOT] Make sure constructing a delegate from a function pointer to an external method works. [crossgen2] Make sure constructing a delegate from a function pointer to an external method works. Oct 2, 2019
@cshung cshung removed their assignment Jan 8, 2020
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@cshung cshung mentioned this issue Jun 23, 2020
Merged
@davidwrighton
Copy link
Member

This was fixed by #38236

@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@janvorli janvorli

Labels
area-crossgen2-coreclr
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
4 participants
@cshung @msftgits @janvorli @davidwrighton