Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the the hoisting of loop invariant expressions that contain Constant ValueNumbers #13467

Open
briansull opened this issue Sep 23, 2019 · 4 comments
Open

Improve the the hoisting of loop invariant expressions that contain Constant ValueNumbers #13467

briansull opened this issue Sep 23, 2019 · 4 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@briansull
Copy link
Contributor

briansull commented Sep 23, 2019 •
edited by BruceForstall
Loading

If the hoisted expression contains any Constant Value numbers that are not true constant nodes we should replace them with true constants.

We can remove the current fix dotnet/coreclr#26551 when we implement this.

category:cq
theme:value-numbering
skill-level:intermediate
cost:medium
impact:small
@briansull
Copy link
Contributor Author

briansull commented Sep 23, 2019 •
edited
Loading

Also we can address:

erozenfeld left a comment
> cleanup and improvements suggestions by @mikedn

dotnet/coreclr#26551 (comment)

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@AndyAyersMS
Copy link
Member

@briansull is this something you think we should work on in 5.0?

@briansull
Copy link
Contributor Author

If this occurs in the Benchmarks or Frameworks then we could implement it.

@AndyAyersMS
Copy link
Member

Ok. If we don't know of any specific cases we want to address right now, let's move this to future.

@AndyAyersMS AndyAyersMS modified the milestones: 5.0, Future Apr 30, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@BruceForstall BruceForstall removed the JitUntriaged CLR JIT issues needing additional triage label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@msftgits @AndyAyersMS @BruceForstall @briansull