-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] CI for pull requests #2394
Comments
Ok, here are the steps to make this happen:
We should start with builds only (no tests for now). We can look at tests later if you see too many functional breakages sneaking through. |
cc @dotnet/runtime-infrastructure |
Can we get some instructions? |
@franksinankaya what kind of instructions do you need? I would suggest starting with: Add sources for docker image with the right Tizen ROOTFS to https://github.com/dotnet/dotnet-buildtools-prereqs-docker repo That repo should have all the necessary instructions, @MichaelSimons is the expert and admin of that repo, in case you need to reach out on the PR to add the necessary images. Once you have dotnet/runtime building for armel locally with that generated image and the image is published on that repo, I can help setting up CI using that docker image. |
@safern |
@alpencolt Do you have any progress on this issue? If you cannot handle it, could I take this issue? |
@alpencolt @gbalykov ARMEL build is broken again by #54954.
Could you add the armel + Tizen CI build leg? Or could I take this issue? |
@clamp03 unfortunately we had no time to this issue. Would be good if you'll take it. |
@alpencolt Thank you. I will handle it. |
I resolved. It is because an invisible character is added in windows GIT. @safern Hi, could you help how to test
Thank you. |
@clamp03 did you figure this out? If not @michaelgsharp or @mthalman would know more about buildtools-prereqs-docker issues. I just see that it can't find sh in your environment, so I don't know if there is a special setup needed in order to build ubuntu images in Windows. |
Cross-build Dockerfiles won't be buildable on a Windows machine because they'll run the Linux-based pre-build hook script which runs on the local machine. Is there a particular set of Dockerfiles you're attempting to test that doesn't include cross-build Dockerfiles? |
@safern @mthalman Thank you for the comments. I made a draft for armel-tizen dotnet/dotnet-buildtools-prereqs-docker#478 My concerns of the PR are
|
The first step is done. dotnet/dotnet-buildtools-prereqs-docker#478 |
@safern Could you help me to add armel checked CI? This is my draft. Is this the right approach?
|
@clamp03 that looks like you are going on the right direction. Also if you shared a branch it would be easier to diff, but overall looks like you are on the right path. |
@alpencolt #56281 is merged. Please close this issue. |
Would be good to have CI builds for Tizen/armel to prevent merging PRs which breaks this platform.
cc @jkotas @gbalykov
The text was updated successfully, but these errors were encountered: