Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure on some platforms when (de)serializing Queue, Stack #2396

Closed
steveharter opened this issue Jan 30, 2020 · 1 comment
Closed
Assignees
Labels
area-System.Text.Json disabled-test The test is disabled in source code against the issue
Milestone

Comments

@steveharter
Copy link
Member

Creating this to flag tests as ActiveIssue to unblock PR #2259

These tests are failing:

System.Text.Json.Serialization.Tests.ValueTests.ReadPrimitiveQueue
System.Text.Json.Serialization.Tests.ValueTests.ReadStackOfArray
System.Text.Json.Serialization.Tests.ValueTests.ReadGenericStackOfStack 
System.Text.Json.Serialization.Tests.ValueTests.ReadArrayOfStack 

on

Linux
OSX
Windows_NET net472

Apparently due to the wrong converter being selected. Message is like:

System.NotSupportedException : Deserialization of reference types without parameterless constructor is not supported. Type 'System.Collections.Queue'

@steveharter steveharter added area-System.Text.Json disabled-test The test is disabled in source code against the issue labels Jan 30, 2020
@layomia layomia assigned jozkee and unassigned layomia Jan 31, 2020
@jozkee
Copy link
Member

jozkee commented Jan 31, 2020

jozkee@5a8ea52
This should fix it, for some reason I am not able to create a PR against your fork...

cc @layomia @GrabYourPitchforks

@ahsonkhan ahsonkhan added this to the 5.0 milestone Feb 21, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

No branches or pull requests

4 participants