-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSocketProtocolTests causing failures in NETFX Outerloop #24967
Comments
We should fix/disable the tests to reduce noise. |
@rmkerr, can you share a link to failure details? |
I added a few links to failed runs in the description. The start date and number of occurrences came from Kusto. If you'd like I can save that info to an excel file and share it as well. |
@rmkerr, thanks. Are there any successful runs of the test on netfx? |
@Priya91, were you successful with this test on netfx? I don't think it can work as written, as the desktop HttpClient will return a read-only stream, which is why the assert is failing. Here's a stripped-down version of the test highlighting the issue:
and it outputs:
The test should be changed to just use a socket directly on the client side, so that it's not reliant on HttpClient behaviors. |
I'll fix it... I need to anyway for dotnet/corefx#26964 to pass on netfx. |
As far as I can tell the test that has issues is |
NETFX Outerloop test runs have been failing for a few weeks now with the following error:
There have been ~200 runs that have failed at the same point. As far as I can tell the issue first occurred on January 18th. Based on that date and an offline discussion with the team I think the issue was probably introduced by PR dotnet/corefx#26429.
You can find a few instances of failed runs here: 1, 2, 3
cc: @Priya91
The text was updated successfully, but these errors were encountered: