Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] Use managed WebSockets implementation for UWP #26136

Closed
caesar-chen opened this issue May 10, 2018 · 5 comments
Closed

[UWP] Use managed WebSockets implementation for UWP #26136

caesar-chen opened this issue May 10, 2018 · 5 comments
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@caesar-chen
Copy link
Contributor

The UWP version of WebSockets.Client currently uses WinRT WebSocket APIs.

We should use managed WebSockets on all Windows (including UWP), and obsolete WinRT implementation.

Related: #17644

@caesar-chen
Copy link
Contributor Author

@karelz I set the Milestone to future, since we will not address it for 2.2. Is that ok?

@karelz
Copy link
Member

karelz commented May 10, 2018

Yep, that's good. Thanks!

@karelz karelz changed the title Use managed WebSockets implementation for UWP [UWP] Use managed WebSockets implementation for UWP May 10, 2018
@davidsh
Copy link
Contributor

davidsh commented May 20, 2018

I started looking into this. One problem doing this is that the managed websocket implementation uses SocketsHttpHandler. And SocketsHttpHandler uses native WinHTTP APIs in order to read the system proxy settings (IE settings) and calculate a proxy (even doing WPAD protcol and Javascript compiling the PAC file).

I don't think the native WinHTTP APIs are in the "allowed" list for a UWP app. We will need to add them.

cc: @danmosemsft

@danmoseley
Copy link
Member

@ptorr-msft is your contact for that

@davidsh
Copy link
Contributor

davidsh commented Oct 17, 2019

This issue was specific to the UAP implementation of the networking stack which had a different implementation for things like HTTP and WebSockets.

As of PR dotnet/corefx#41759, we no longer build the separate implementation for the UAP platform. So, this issue can't occur anymore with .NET 5 because we now will be using the same .NET Core implementation as on Windows, Linux, Mac.

@davidsh davidsh closed this as completed Oct 17, 2019
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

5 participants