Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multicast Socket tests failing on Nano #26286

Closed
davidsh opened this issue May 25, 2018 · 0 comments · Fixed by dotnet/corefx#36864
Closed

Multicast Socket tests failing on Nano #26286

davidsh opened this issue May 25, 2018 · 0 comments · Fixed by dotnet/corefx#36864
Assignees
@davidsh
Labels
area-System.Net.Sockets disabled-test The test is disabled in source code against the issue os-windows-nano Nano Windows SKU
Milestone
3.0

Comments

@davidsh
Copy link
Contributor

davidsh commented May 25, 2018

dotnet/corefx#29903 (comment)

The Sockets multicast tests are failing on Nano:
https://mc.dot.net/#/user/davidsh/pr~2Fjenkins~2Fdotnet~2Fcorefx~2Fmaster~2F/test~2Ffunctional~2Fcli~2F/5f5dae7b004d88bdc2927927d655380c56087396/workItem/System.Net.Sockets.Tests

System.Net.Sockets.SocketException : The requested address is not valid in its context.
@davidsh davidsh self-assigned this May 25, 2018
davidsh referenced this issue in dotnet/corefx May 25, 2018
@davidsh
Disable multicast socket tests on Nano (#29931)
71ff387 
See: #29929
@davidsh davidsh removed their assignment May 25, 2018
maryamariyan referenced this issue in maryamariyan/corefx May 30, 2018
@davidsh @maryamariyan
Disable multicast socket tests on Nano (dotnet#29931)
6aeff34 
See: #29929
 Conflicts:
	src/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs
danmoseley referenced this issue in dotnet/corefx May 31, 2018
@maryamariyan @danmoseley
[release/2.1] Port nano test fixes (#29995)
77a4a19 
* Disable SafeServiceControllerTests.GetServices test (#29924)

https://github.com/dotnet/corefx/issues/19223

* Disable serial ports tests on Windows Nano (#29793)

Fix #29756

* Merge pull request #29789 from stephentoub/nanotests

Disable some tests on Nano server

* Disable multicast socket tests on Nano (#29931)

See: #29929
 Conflicts:
	src/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs

* Disable System.DirectoryServices ActiveDirectory tests on Nano Server (#29857)

* Replaces ConditionalClass with ConditionalFact or ConditionalTheory
@davidsh davidsh self-assigned this Apr 14, 2019
davidsh referenced this issue in davidsh/corefx Apr 14, 2019
@davidsh
Cleanup SocketOptionNameTest
0d57179 
One of the oldest issues #4887 was about the Windows socket option, ReuseUnicastPort.
This test was disabled several years ago because it was very difficult to test in CI since it
required not only a newer version of Windows but also specific network settings on the machine.

At this point, there is not any way to reliably test this. And the end-to-end test isn't really
of high value for .NET Core since we would really be mostly testing an OS feature.

As part of cleaning that issue up, I cleaned up the rest of the tests, some of which were marked
as Outerloop but didn't need to be.

Closes #29929
Closes #21327
Closes #4887
stephentoub referenced this issue in dotnet/corefx Apr 15, 2019
@davidsh @stephentoub
Cleanup SocketOptionNameTest (#36864)
f389a14 
One of the oldest issues #4887 was about the Windows socket option, ReuseUnicastPort.
This test was disabled several years ago because it was very difficult to test in CI since it
required not only a newer version of Windows but also specific network settings on the machine.

At this point, there is not any way to reliably test this. And the end-to-end test isn't really
of high value for .NET Core since we would really be mostly testing an OS feature.

As part of cleaning that issue up, I cleaned up the rest of the tests, some of which were marked
as Outerloop but didn't need to be.

Closes #29929
Closes #21327
Closes #4887
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidsh davidsh

Labels
area-System.Net.Sockets disabled-test The test is disabled in source code against the issue os-windows-nano Nano Windows SKU
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Cleanup SocketOptionNameTest davidsh/corefx
2 participants
@davidsh @msftgits