Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if RSA/DSA FromXmlString can avoid reflection #29555

Open
bartonjs opened this issue May 15, 2019 · 2 comments
Open

Investigate if RSA/DSA FromXmlString can avoid reflection #29555

bartonjs opened this issue May 15, 2019 · 2 comments

Comments

@bartonjs
Copy link
Member

It seems that via the System.Xml.ReaderWriter contract assembly the compiler doesn't notice the cyclic dependency

  • System.Security.Cryptography.Algorithms references System.Xml.ReaderWriter
  • System.Xml.ReaderWriter forwards to System.Private.Xml
  • System.Private.Xml references System.Net.Requests
  • System.Net.Requests references System.Security.Cryptography.X509Certificates
  • System.Security.Cryptography.X509Certificates references System.Security.Cryptography.Algorithms

Maybe that's a better model than reflection.

@Wraith2
Copy link
Contributor

Wraith2 commented May 15, 2019

From what i remember the original desktop framework version had a small xml parser specifically to avoid this loop. Any reason not to use it?

@bartonjs
Copy link
Member Author

I'm not an adherent of the school that says more different pieces doing the same thing is better :) I'd way rather use something that's being maintained than an internal parser that no one ever looks at

@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the Future milestone Feb 1, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@bartonjs bartonjs removed the untriaged New issue has not been triaged by the area owner label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants