Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Don't leak QUIC session upon QuicListener disposal #32073

Closed
scalablecory opened this issue Feb 10, 2020 · 4 comments
Closed

[QUIC] Don't leak QUIC session upon QuicListener disposal #32073

scalablecory opened this issue Feb 10, 2020 · 4 comments
Labels
Milestone

Comments

@scalablecory
Copy link
Contributor

We have a hang in QuicListener.Dispose() and are currently working around it by just not disposing of the session.

// TODO this call to session dispose hangs.
//_session.Dispose();
_disposed = true;

@scalablecory scalablecory added this to the 5.0 milestone Feb 10, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Feb 10, 2020
@scalablecory scalablecory removed the untriaged New issue has not been triaged by the area owner label Feb 10, 2020
@karelz karelz added bug tenet-performance Performance related issue labels Feb 20, 2020
@karelz karelz changed the title Don't leak QUIC session upon QuicListener disposal [QUIC] Don't leak QUIC session upon QuicListener disposal Mar 11, 2020
@scalablecory scalablecory modified the milestones: 5.0.0, 6.0.0 Aug 11, 2020
@scalablecory
Copy link
Contributor Author

Moving this to 6.0, @jkotalik does that sound okay given this will be experimental feature, and QuicListener is generally disposed at end of program in ASP.NET?

@ManickaP
Copy link
Member

Has this been solved by: #49823 ??? Seems to me like it has. We might close this.
@scalablecory

@scalablecory
Copy link
Contributor Author

scalablecory commented Apr 22, 2021

Triage: this is probably solved due to not holding a ref to session anymore (now it is configuration, and MsQuic ref counts that itself.) -- double check code and close if it's fixed.

@ManickaP

@ManickaP
Copy link
Member

We're disposing the configuration properly:

Closing, this was solved in #49823

@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants