Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to base host RID for Microsoft.DotNet.PlatformAbstractions #3329

Closed
akihikodaki opened this issue Nov 3, 2018 · 1 comment
Closed
Milestone

Comments

@akihikodaki
Copy link

dotnet/core-setup#1689 implemented fallback to base host RID for corehost, but it doesn't for Microsoft.DotNet.PlatformAbstractions.

It must noted that Microsoft.DotNet.PlatformAbstractions is on level lower than corehost when implementing such a mechanism, you; corehost knows RID graph, but Microsoft.DotNet.PlatformAbstractions doesn't. There should be two options due to that:

  • Add a code to interpret RID graph and transform the API higher level
  • Add yet another low level method, GetRIDOSFallback or something similar, which corresponds to pal::get_current_os_fallback_rid

I'd like to know how this problem will actually be solved (one of these two or possible something different.) Thanks.

Steps to reproduce

  1. Use Microsoft.DotNet.PlatformAbstractions on an exotic platform (on Arch Linux in my case)

Expected behavior

It reports known RID such as linux-x64.

Actual behavior

It reports unknown RID such as arch-x64.

Environment data

$ cat /etc/os-release
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
ID_LIKE=archlinux
ANSI_COLOR="0;36"
HOME_URL="https://www.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://bugs.archlinux.org/"
@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@msftgits msftgits added this to the Future milestone Jan 30, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Feb 24, 2020
@eerhardt
Copy link
Member

We've added the RuntimeInformation.RuntimeIdentifier API in .NET 5 (#26780 and #34206). This API will use the fallback RID since it uses the same information as the corehost.

We are removing the PlatformAbstractions library with #3470, and recommending to use the new RuntimeInformation.RuntimeIdentifier API to get the RID of the current machine.

Closing this issue.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants