Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RID for 32bit ios #33982

Closed
marek-safar opened this issue Mar 23, 2020 · 1 comment · Fixed by #33990
Closed

Add RID for 32bit ios #33982

marek-safar opened this issue Mar 23, 2020 · 1 comment · Fixed by #33990

Comments

@marek-safar
Copy link
Contributor

This would be straight forward if Apple didn't drop the support for 32bits in the recent versions. The last supported 32bit version is ios 10.

RIDs for other ios architectures already exist and only 32 bit needs to be added up to ios-10-arm.

@ericstj please advice on the correct logic.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Mar 23, 2020
@ericstj
Copy link
Member

ericstj commented Mar 24, 2020

You should be able to define separate groups. Any overlapping RIDs will be dedup-ed so long as they have the same imports. I submitted a PR based on what I think you want. Please review.

@ericstj ericstj self-assigned this Mar 24, 2020
@ericstj ericstj removed the untriaged New issue has not been triaged by the area owner label Mar 24, 2020
@ericstj ericstj added this to the 5.0 milestone Mar 24, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants