Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure when building libraries build with -allConfigurations #34200

Closed
dseefeld opened this issue Mar 27, 2020 · 8 comments
Closed

Build failure when building libraries build with -allConfigurations #34200

dseefeld opened this issue Mar 27, 2020 · 8 comments

Comments

@dseefeld
Copy link
Contributor

Build environment:
Centos7 - Docker image: mcr.microsoft.com/dotnet-buildtools/prereqs:centos-7-6aaa05d-20191106231356

Build commands:
./build.sh -subsetCategory coreclr
./build.sh -subsetCategory libraries -allConfigurations

Resulting errors from libraries build:

/root/.nuget/packages/microsoft.dotnet.genfacades/5.0.0-beta.20171.1/build/Microsoft.DotNet.GenPartialFacadeSource.targets(30,5): error : Did not find type 'System.Runtime.InteropServices.WindowsRuntime.DefaultInterfaceAttribute' in any of the seed assemblies. [/src/runtime2/src/libraries/System.Runtime.InteropServices.WindowsRuntime/src/System.Runtime.InteropServices.WindowsRuntime.csproj]
/root/.nuget/packages/microsoft.dotnet.genfacades/5.0.0-beta.20171.1/build/Microsoft.DotNet.GenPartialFacadeSource.targets(30,5): error : Did not find type 'System.Runtime.InteropServices.WindowsRuntime.EventRegistrationToken' in any of the seed assemblies. [/src/runtime2/src/libraries/System.Runtime.InteropServices.WindowsRuntime/src/System.Runtime.InteropServices.WindowsRuntime.csproj]
/root/.nuget/packages/microsoft.dotnet.genfacades/5.0.0-beta.20171.1/build/Microsoft.DotNet.GenPartialFacadeSource.targets(30,5): error : Did not find type 'System.Runtime.InteropServices.WindowsRuntime.EventRegistrationTokenTable`1' in any of the seed assemblies. [/src/runtime2/src/libraries/System.Runtime.InteropServices.WindowsRuntime/src/System.Runtime.InteropServices.WindowsRuntime.csproj]
/root/.nuget/packages/microsoft.dotnet.genfacades/5.0.0-beta.20171.1/build/Microsoft.DotNet.GenPartialFacadeSource.targets(30,5): error : Did not find type 'System.Runtime.InteropServices.WindowsRuntime.IActivationFactory' in any of the seed assemblies. [/src/runtime2/src/libraries/System.Runtime.InteropServices.WindowsRuntime/src/System.Runtime.InteropServices.WindowsRuntime.csproj]
/root/.nuget/packages/microsoft.dotnet.genfacades/5.0.0-beta.20171.1/build/Microsoft.DotNet.GenPartialFacadeSource.targets(30,5): error : Did not find type 'System.Runtime.InteropServices.WindowsRuntime.InterfaceImplementedInVersionAttribute' in any of the seed assemblies. [/src/runtime2/src/libraries/System.Runtime.InteropServices.WindowsRuntime/src/System.Runtime.InteropServices.WindowsRuntime.csproj]
/root/.nuget/packages/microsoft.dotnet.genfacades/5.0.0-beta.20171.1/build/Microsoft.DotNet.GenPartialFacadeSource.targets(30,5): error : Did not find type 'System.Runtime.InteropServices.WindowsRuntime.ReadOnlyArrayAttribute' in any of the seed assemblies. [/src/runtime2/src/libraries/System.Runtime.InteropServices.WindowsRuntime/src/System.Runtime.InteropServices.WindowsRuntime.csproj]
/root/.nuget/packages/microsoft.dotnet.genfacades/5.0.0-beta.20171.1/build/Microsoft.DotNet.GenPartialFacadeSource.targets(30,5): error : Did not find type 'System.Runtime.InteropServices.WindowsRuntime.ReturnValueNameAttribute' in any of the seed assemblies. [/src/runtime2/src/libraries/System.Runtime.InteropServices.WindowsRuntime/src/System.Runtime.InteropServices.WindowsRuntime.csproj]
/root/.nuget/packages/microsoft.dotnet.genfacades/5.0.0-beta.20171.1/build/Microsoft.DotNet.GenPartialFacadeSource.targets(30,5): error : Did not find type 'System.Runtime.InteropServices.WindowsRuntime.WindowsRuntimeMarshal' in any of the seed assemblies. [/src/runtime2/src/libraries/System.Runtime.InteropServices.WindowsRuntime/src/System.Runtime.InteropServices.WindowsRuntime.csproj]
/root/.nuget/packages/microsoft.dotnet.genfacades/5.0.0-beta.20171.1/build/Microsoft.DotNet.GenPartialFacadeSource.targets(30,5): error : Did not find type 'System.Runtime.InteropServices.WindowsRuntime.WriteOnlyArrayAttribute' in any of the seed assemblies. [/src/runtime2/src/libraries/System.Runtime.InteropServices.WindowsRuntime/src/System.Runtime.InteropServices.WindowsRuntime.csproj]
System/IO/StreamOperationAsyncResult.cs(5,40): error CS0234: The type or namespace name 'WindowsRuntime' does not exist in the namespace 'Internal.Runtime.InteropServices' (are you missing an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Threading/Tasks/AsyncInfoToTaskBridge.cs(5,40): error CS0234: The type or namespace name 'WindowsRuntime' does not exist in the namespace 'Internal.Runtime.InteropServices' (are you missing an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Threading/WindowsRuntimeSynchronizationContext.cs(5,40): error CS0234: The type or namespace name 'WindowsRuntime' does not exist in the namespace 'Internal.Runtime.InteropServices' (are you missing an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/WindowsRuntimeSystemExtensions.cs(5,40): error CS0234: The type or namespace name 'WindowsRuntime' does not exist in the namespace 'Internal.Runtime.InteropServices' (are you missing an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Resources/WindowsRuntimeResourceManager.cs(6,16): error CS0234: The type or namespace name 'Resources' does not exist in the namespace 'Internal' (are you missing an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Resources/WindowsRuntimeResourceManager.cs(26,59): error CS0246: The type or namespace name 'WindowsRuntimeResourceManagerBase' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(46,9): error CS0246: The type or namespace name 'EventRegistrationToken' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(47,39): error CS0246: The type or namespace name 'EventRegistrationToken' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(56,9): error CS0246: The type or namespace name 'EventRegistrationToken' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(57,37): error CS0246: The type or namespace name 'EventRegistrationToken' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(66,9): error CS0246: The type or namespace name 'EventRegistrationToken' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(67,39): error CS0246: The type or namespace name 'EventRegistrationToken' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(455,17): error CS0246: The type or namespace name 'EventRegistrationToken' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(468,47): error CS0246: The type or namespace name 'EventRegistrationToken' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(451,64): error CS0246: The type or namespace name 'EventRegistrationTokenTable<>' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(268,18): error CS0246: The type or namespace name 'EventRegistrationToken' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(280,48): error CS0246: The type or namespace name 'EventRegistrationToken' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(264,80): error CS0246: The type or namespace name 'EventRegistrationTokenTable<>' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(349,18): error CS0246: The type or namespace name 'EventRegistrationToken' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(361,46): error CS0246: The type or namespace name 'EventRegistrationToken' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs(345,78): error CS0246: The type or namespace name 'EventRegistrationTokenTable<>' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Resources/WindowsRuntimeResourceManager.cs(342,82): error CS0246: The type or namespace name 'PRIExceptionInfo' could not be found (are you missing a using directive or an assembly reference?) [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Resources/WindowsRuntimeResourceManager.cs(441,37): error CS0115: 'WindowsRuntimeResourceManager.GlobalResourceContextBestFitCultureInfo': no suitable method found to override[/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Resources/WindowsRuntimeResourceManager.cs(452,30): error CS0115: 'WindowsRuntimeResourceManager.SetGlobalResourceContextDefaultCulture(CultureInfo)': no suitable method foundto override [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
System/Resources/WindowsRuntimeResourceManager.cs(504,33): error CS0115: 'WindowsRuntimeResourceManager.GetString(string, string?, string?)': no suitable method found to override [/src/runtime2/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj]
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Runtime untriaged New issue has not been triaged by the area owner labels Mar 27, 2020
@ericstj
Copy link
Member

ericstj commented Apr 3, 2020

I believe we never made -allConfigurations work for Source-Build. That pass is specifically about covering stuff that doesn't target the latest framework.

@ericstj ericstj added area-Infrastructure-libraries question Answer questions and provide assistance, not an issue with source code or documentation. and removed area-System.Runtime untriaged New issue has not been triaged by the area owner labels Apr 3, 2020
@ghost
Copy link

ghost commented Apr 3, 2020

Tagging @safern, @ViktorHofer as an area owner

@ericstj ericstj added this to the 5.0 milestone Apr 3, 2020
@ericstj ericstj self-assigned this Apr 3, 2020
@safern
Copy link
Member

safern commented Apr 3, 2020

I believe we never made -allConfigurations work for Source-Build.

Also, did we make it work for Unix? It seems like this case is because of a difference in the surface area of System.Private.CoreLib in between Unix and Windows.

@ViktorHofer
Copy link
Member

I believe @krwq made the -allconfigurations leg on Unix work sometime around last year.

@ericstj
Copy link
Member

ericstj commented Apr 3, 2020

This is totally different: this is source build. It's against the principle of source build (building current product from source) to build all configurations (including those for frameworks shipped 10 years ago).

@ericstj
Copy link
Member

ericstj commented Apr 3, 2020

That said, I do think this error is likely a regression of -allConfigurations on linux outside the context of source build. It's caused by the live-build work in runtime.depproj -> it's no longer restoring windows CoreLib when building Windows version of these assemblies on a Unix machine. /cc @jkoritzinsky We might want to just open a separate issue for that.

@ericstj
Copy link
Member

ericstj commented Apr 3, 2020

I see @dseefeld didn't mention source-build in this issue (only offline) so I guess we can use this issue to track the regression in allConfigurations on unix due to live-live

@ericstj ericstj removed their assignment Apr 3, 2020
@ericstj ericstj added bug regression-from-last-release and removed question Answer questions and provide assistance, not an issue with source code or documentation. labels Apr 3, 2020
@ericstj
Copy link
Member

ericstj commented Jul 20, 2020

This should be working now. All of the problem types were removed from CoreLib with #36715

@ericstj ericstj closed this as completed Jul 20, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants