-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure when building libraries build with -allConfigurations #34200
Comments
I believe we never made -allConfigurations work for Source-Build. That pass is specifically about covering stuff that doesn't target the latest framework. |
Tagging @safern, @ViktorHofer as an area owner |
Also, did we make it work for Unix? It seems like this case is because of a difference in the surface area of System.Private.CoreLib in between Unix and Windows. |
I believe @krwq made the |
This is totally different: this is source build. It's against the principle of source build (building current product from source) to build all configurations (including those for frameworks shipped 10 years ago). |
That said, I do think this error is likely a regression of -allConfigurations on linux outside the context of source build. It's caused by the live-build work in runtime.depproj -> it's no longer restoring windows CoreLib when building Windows version of these assemblies on a Unix machine. /cc @jkoritzinsky We might want to just open a separate issue for that. |
I see @dseefeld didn't mention source-build in this issue (only offline) so I guess we can use this issue to track the regression in allConfigurations on unix due to live-live |
This should be working now. All of the problem types were removed from CoreLib with #36715 |
Build environment:
Centos7 - Docker image: mcr.microsoft.com/dotnet-buildtools/prereqs:centos-7-6aaa05d-20191106231356
Build commands:
./build.sh -subsetCategory coreclr
./build.sh -subsetCategory libraries -allConfigurations
Resulting errors from libraries build:
The text was updated successfully, but these errors were encountered: