Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uri] Consider caching PathAndQuery #34618

Closed
stephentoub opened this issue Apr 7, 2020 · 1 comment · Fixed by #36460
Closed

[Uri] Consider caching PathAndQuery #34618

stephentoub opened this issue Apr 7, 2020 · 1 comment · Fixed by #36460
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions tenet-performance Performance related issue
Milestone
5.0.0

Comments

@stephentoub
Copy link
Member

Uri caches several results that are likely to be accessed again. It doesn't do so for Uri.PathAndQuery, but this property is used on every request made by SocketsHttpHandler. We should consider caching it, for scenarios where the same Url is used repeatedly with an HttpClient. As with any caching, though, we'd want to make sure it was actually worthwhile and didn't negatively impact other important cases.

cc: @scalablecory, @MihaZupan
@stephentoub stephentoub added this to the 5.0 milestone Apr 7, 2020
@stephentoub stephentoub added the untriaged New issue has not been triaged by the area owner label Apr 7, 2020
@MihaZupan MihaZupan changed the title Consider caching Uri.PathAndQuery [Uri] Consider caching PathAndQuery Apr 11, 2020
@MihaZupan MihaZupan mentioned this issue Apr 13, 2020
Closed
@MihaZupan MihaZupan mentioned this issue Apr 30, 2020
Closed
@karelz karelz added enhancement Product code improvement that does NOT require public API changes/additions tenet-performance Performance related issue and removed untriaged New issue has not been triaged by the area owner labels May 14, 2020
@karelz
Copy link
Member

karelz commented May 14, 2020

Triage: Helps gRPC scenarios perf.

@MihaZupan MihaZupan mentioned this issue May 14, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions tenet-performance Performance related issue
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Cache Uri.IdnHost and Uri.PathAndQuery MihaZupan/runtime
2 participants
@stephentoub @karelz