Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/libraries/tests.proj contains incorrect condition #34788

Closed
janvorli opened this issue Apr 9, 2020 · 3 comments · Fixed by #34829
Closed

src/libraries/tests.proj contains incorrect condition #34788

janvorli opened this issue Apr 9, 2020 · 3 comments · Fixed by #34829
Assignees
@safern
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner
Milestone
5.0.0

Comments

@janvorli
Copy link
Member

janvorli commented Apr 9, 2020

The test run complains:
F:\git\runtime4\src\libraries\tests.proj(24,11): error MSB4092: An unexpected token "==" was found at character position 25 in condition "'$(Coverage)' == 'true' == 'true' and '$(SkipCoverageReport)' != 'true'".
@janvorli janvorli added this to the 5.0 milestone Apr 9, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Apr 9, 2020
@danmoseley
Copy link
Member

@safern this was broken by #33553

@safern
Copy link
Member

safern commented Apr 9, 2020

I'll take a look and put up a PR in a few mins.

@ghost
Copy link

ghost commented Apr 9, 2020

Tagging @safern, @ViktorHofer as an area owner

@safern safern self-assigned this Apr 9, 2020
@safern safern mentioned this issue Apr 10, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@safern safern

Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix GenerateCoverageReport target in tests.proj safern/runtime
4 participants
@danmoseley @janvorli @safern @Dotnet-GitSync-Bot