Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deferred loading of System.Private.Uri assembly by the serializer. #35029

Closed
steveharter opened this issue Apr 15, 2020 · 1 comment
Closed

Add deferred loading of System.Private.Uri assembly by the serializer. #35029

steveharter opened this issue Apr 15, 2020 · 1 comment
Assignees
@steveharter
Labels
area-System.Text.Json tenet-build-performance Impacts build time: official, developer or CI
Milestone
5.0.0

Comments

@steveharter
Copy link
Member

As part of researching approaches to #1568 it was found that we can avoid loading the System.Private.Uri assembly. This will slightly help CPU performance and reduce memory consumption when System.Uri is not referenced otherwise (such as on a POCO property).
@steveharter steveharter added area-System.Text.Json tenet-build-performance Impacts build time: official, developer or CI labels Apr 15, 2020
@steveharter steveharter added this to the 5.0 milestone Apr 15, 2020
@steveharter steveharter self-assigned this Apr 15, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Apr 15, 2020
@layomia layomia removed the untriaged New issue has not been triaged by the area owner label Apr 17, 2020
@steveharter steveharter mentioned this issue Apr 30, 2020
Closed
@steveharter
Copy link
Member Author

Closing for now until we have a solution for all converters. More detail in the PR linked above.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@steveharter steveharter

Labels
area-System.Text.Json tenet-build-performance Impacts build time: official, developer or CI
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Lazy load System.Private.Uri.dll steveharter/runtime
3 participants
@steveharter @layomia @Dotnet-GitSync-Bot