Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the enforcepgo script fails, it doesn't fail the CoreCLR build #35089

Closed
jkoritzinsky opened this issue Apr 17, 2020 · 1 comment · Fixed by #46019
Closed

If the enforcepgo script fails, it doesn't fail the CoreCLR build #35089

jkoritzinsky opened this issue Apr 17, 2020 · 1 comment · Fixed by #46019
Labels
area-Infrastructure-coreclr help wanted [up-for-grabs] Good issue for external contributors
Milestone
Future

Comments

@jkoritzinsky
Copy link
Member

jkoritzinsky commented Apr 17, 2020 •
edited by trylek
Loading

Initial cost estimate: 2 days
Initial contacts: @trylek, @jkoritzinsky

As reported in #34069 (comment), when the enforcepgo script fails, the build-runtime.cmd script still succeeds. A failing enforcepgo step should fail the build.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-coreclr untriaged New issue has not been triaged by the area owner labels Apr 17, 2020
@jashook jashook removed the untriaged New issue has not been triaged by the area owner label May 11, 2020
@jashook jashook added this to the Future milestone Jul 17, 2020
@trylek trylek mentioned this issue Nov 8, 2020
Open
15 tasks
@jkoritzinsky jkoritzinsky mentioned this issue Dec 13, 2020
Merged
@jkoritzinsky jkoritzinsky linked a pull request Dec 13, 2020 that will close this issue
Fix previously overlooked path to pgocheck.py (src/coreclr/src) #46019
Merged
@hoyosjs hoyosjs reopened this Jan 7, 2021
@trylek trylek added the help wanted [up-for-grabs] Good issue for external contributors label Mar 2, 2021
@jkoritzinsky
Copy link
Member Author

This looks like it's been fixed. Closing.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure-coreclr help wanted [up-for-grabs] Good issue for external contributors
Projects
Runtime Infra
Archived in project
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Fix previously overlooked path to pgocheck.py (src/coreclr/src) trylek/runtime
5 participants
@jkoritzinsky @jashook @trylek @hoyosjs @Dotnet-GitSync-Bot