Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer's HostMachineRidTargetsDebianPackages should check for Debian in a better way #35607

Open
eerhardt opened this issue Apr 29, 2020 · 2 comments

Comments

@eerhardt
Copy link
Member

Instead of hard-coding a couple RIDs to see if the host machine is "debian based":

<HostMachineRidTargetsDebianPackages Condition="
$(HostMachineRid.StartsWith('debian')) or
$(HostMachineRid.StartsWith('ubuntu')) or
$(HostMachineRid.StartsWith('linuxmint'))">true</HostMachineRidTargetsDebianPackages>
<!-- If the build machine isn't known to be Debian-based, try to build RPM packages. -->
<HostMachineRidTargetsRpmPackages Condition="'$(HostMachineRidTargetsDebianPackages)' != 'true'">true</HostMachineRidTargetsRpmPackages>

We should instead use a more proper way of checking for Debian systems.

One example would be to check for the existence of /etc/debian_version. See #35538 (comment).

fyi - @jkotas @ViktorHofer

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Apr 29, 2020
@ghost
Copy link

ghost commented Apr 29, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@NikolaMilosavljevic
Copy link
Member

[Triage] This would affect source-building .NET in Debian family of distros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants