Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libnethost.lib in shared directory #35616

Closed
AaronRobinsonMSFT opened this issue Apr 29, 2020 · 7 comments
Closed

libnethost.lib in shared directory #35616

AaronRobinsonMSFT opened this issue Apr 29, 2020 · 7 comments
Assignees
@VSadov
Labels
area-Host

Comments

@AaronRobinsonMSFT
Copy link
Member

AaronRobinsonMSFT commented Apr 29, 2020 •
edited
Loading

The static library version of nethost.dll is located in the shared/ directory with coreclr.dll. This was discovered in the nightly build and shouldn't be there. For example:

shared\Microsoft.NETCore.App\5.0.0-preview.5.20228.12\libnethost.lib

The macOS and linux archives weren't checked.

/cc @vitek-karas @swaroop-sridhar @elinor-fung
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Apr 29, 2020
@vitek-karas
Copy link
Member

@swaroop-sridhar @VSadov could one of you please take this and get it fixed?

@VSadov VSadov self-assigned this Apr 29, 2020
@swaroop-sridhar swaroop-sridhar removed the untriaged New issue has not been triaged by the area owner label Apr 29, 2020
@AaronRobinsonMSFT
Copy link
Member Author

AaronRobinsonMSFT commented Jun 14, 2020 •
edited
Loading

@VSadov @vitek-karas This seems to no longer be shipped in shared\Microsoft.NETCore.App - yay, but is now no longer shipped at all - boo. This is breaking tools like https://github.com/AaronRobinsonMSFT/DNNE that rely on the static lib of nethost - libnethost.lib.

I verified this on the nightly build on Windows - 5.0.0-preview.7.20313.3.

This was referenced Jun 14, 2020
Merged
Closed
@ghost
Copy link

ghost commented Jul 8, 2020

Tagging subscribers to this area: @vitek-karas, @swaroop-sridhar, @agocke
Notify danmosemsft if you want to be subscribed.

@AaronRobinsonMSFT
Copy link
Member Author

@jkoritzinsky This is an issue I hope some of your work on setup will address.

@VSadov
Copy link
Member

VSadov commented Aug 6, 2020 •
edited
Loading

I have checked shared\Microsoft.NETCore.App\5.0.0-rc.1.20404.16 and libnethost.lib is there. As I understand this is undesirable.

Where should it be though?
I do not have enough context to figure that from the issue description.

@AaronRobinsonMSFT
Copy link
Member Author

AaronRobinsonMSFT commented Aug 6, 2020 •
edited
Loading

It is superfluous in this location - it is never used. The libnethost.lib libraries are deployed in the apphost package and have no purpose in the actual Microsoft.NETCore.App location.

@VSadov VSadov mentioned this issue Aug 13, 2020
Merged
@VSadov
Copy link
Member

VSadov commented Aug 13, 2020

Fixed in: #40754

@VSadov VSadov closed this as completed Aug 13, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@VSadov VSadov

Labels
area-Host
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@VSadov @swaroop-sridhar @NikolaMilosavljevic @vitek-karas @AaronRobinsonMSFT @Dotnet-GitSync-Bot