Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SuperPMI checked/release failures #39947

Closed
BruceForstall opened this issue Jul 27, 2020 · 3 comments · Fixed by #40340
Closed

SuperPMI checked/release failures #39947

BruceForstall opened this issue Jul 27, 2020 · 3 comments · Fixed by #40340
Assignees
@sandreenko
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows
Milestone
5.0.0

Comments

@BruceForstall
Copy link
Member

BruceForstall commented Jul 27, 2020 •
edited
Loading

Run SuperPMI in asm diff mode using Checked and Release JIT (Windows x64), on the full frameworks + tests collection, e.g.:

f:\gh\runtime\artifacts\tests\coreclr\Windows_NT.x64.Checked\Tests\Core_Root\superpmi.exe -p -f fail.mcl -a -jitoption force AltJit= -jitoption force AltJitNgen= f:\gh\runtime\artifacts\bin\coreclr\Windows_NT.x64.Checked\clrjit.dll f:\gh\runtime\artifact
s\bin\coreclr\Windows_NT.x64.Release\clrjit.dll f:\spmi\runtime_collection\collections\tests.pmi.Windows_NT.x64.Release.mch

I see 926 of:

ERROR: Exception thrown: SuperPMI assertion 'IsStructRequiringStackAllocRetBuf != nullptr' failed ("Found a null IsStructRequiringStackAllocRetBuf.  Probably missing a fatTrigger for 00007FFD79C3C920.")

and 1:

ERROR: Exception thrown: SuperPMI assertion 'IsStructRequiringStackAllocRetBuf->GetIndex((DWORDLONG)cls) != -1' failed ("Didn't find 00007FFD79BEED58")

I would expect there not to be any errors. The collection was done using a Windows x64 Checked JIT. A Release JIT shouldn't ask any different questions, so the Checked collection should be usable.

Related? #39908

category:correctness
theme:testing
skill-level:intermediate
cost:medium
@BruceForstall BruceForstall added os-windows arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jul 27, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jul 27, 2020
@BruceForstall
Copy link
Member Author

cc @dotnet/jit-contrib

@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Jul 27, 2020
@AndyAyersMS
Copy link
Member

Do we want this in 5.0?

@BruceForstall BruceForstall added this to the 5.0.0 milestone Jul 27, 2020
@BruceForstall
Copy link
Member Author

Yes.

@sandreenko sandreenko self-assigned this Aug 3, 2020
@sandreenko sandreenko mentioned this issue Aug 4, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandreenko sandreenko

Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Check more patterns for retBuffer. sandreenko/runtime
4 participants
@AndyAyersMS @BruceForstall @sandreenko @Dotnet-GitSync-Bot