Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.IO.Tests.File_Copy tests failing on Browser wasm #40867

Closed
jozkee opened this issue Aug 14, 2020 · 1 comment · Fixed by #41048
Closed

System.IO.Tests.File_Copy tests failing on Browser wasm #40867

jozkee opened this issue Aug 14, 2020 · 1 comment · Fixed by #41048
Assignees
Labels
arch-wasm WebAssembly architecture area-System.IO
Milestone

Comments

@jozkee
Copy link
Member

jozkee commented Aug 14, 2020

Triggered by #40753.

First:

      [FAIL] System.IO.Tests.File_Copy_str_str_b.CopyFileWithData(data: [], readOnly: False)
      Assert.InRange() Failure
      Range:  (08/14/2020 23:38:44 - 08/14/2020 23:38:46)
      Actual: 08/14/2020 22:38:45
         at System.IO.Tests.File_Copy_str_str.CopyFileWithData(Char[] data, Boolean readOnly)
         at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Second (this is a new test just added on #40753):

      [FAIL] System.IO.Tests.File_Copy_Single.EnsureThrowWhenCopyToNonSharedFile
      Assert.Throws() Failure
      Expected: typeof(System.IO.IOException)
      Actual:   (No exception was thrown)
         at System.IO.Tests.File_Copy_Single.EnsureThrowWhenCopyToNonSharedFile()
         at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
@jozkee jozkee added arch-wasm WebAssembly architecture area-System.IO labels Aug 14, 2020
@jozkee jozkee added this to the 5.0.0 milestone Aug 14, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Aug 14, 2020
@steveisok steveisok removed the untriaged New issue has not been triaged by the area owner label Aug 15, 2020
@mdh1418
Copy link
Member

mdh1418 commented Aug 19, 2020

At first glance it looks like EnsureThrowWhenCopyToNonSharedFile does not throw an error on wasm because flock is not yet implemented on emscripten emscripten-core/emscripten#11797.
Because there is only one process on WASM, locking would not work.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.IO
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants