-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not run stackLevelSetter
except for x86.
#42673
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Comments
sandreenko
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 24, 2020
Dotnet-GitSync-Bot
added
the
untriaged
New issue has not been triaged by the area owner
label
Sep 24, 2020
jeffschwMSFT
removed
the
untriaged
New issue has not been triaged by the area owner
label
Sep 24, 2020
JulieLeeMSFT
added
the
needs-further-triage
Issue has been initially triaged, but needs deeper consideration or reconsideration
label
Mar 23, 2021
sandreenko
added
Priority:2
Work that is important, but not critical for the release
and removed
needs-further-triage
Issue has been initially triaged, but needs deeper consideration or reconsideration
labels
Apr 5, 2021
Moving to future unless we have time after #7996 to do this. |
BruceForstall
removed
the
Priority:2
Work that is important, but not critical for the release
label
May 17, 2023
I am now co-opting this phase to also scan for unused throw helper blocks, so we will just be running it always. |
#95379 now uses this phase for trimming throw helpers. So, closing this. TP hit from running this phase (non-x86) is around 0.2% |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Stack level setter is required only for x86, on other platforms, it could be skipped or run only in debug.
However, there is an issue with disabling it:
Stack level setter has code that was supposed to be run only on x86 but is running on all platforms currently:
runtime/src/coreclr/src/jit/stacklevelsetter.cpp
Lines 328 to 340 in 5cded6d
If you put it under
TARGET_X86
as I did in #42197 you will see a big size regressions because you will have to encode bigger offset (from the rsp instead of saved rsp+offset):and also see bunch of new bad LSRA decisions.
category:implementation
theme:throughput
skill-level:beginner
cost:small
The text was updated successfully, but these errors were encountered: