Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move name resolution cancellation test into Docker #43816

Closed
scalablecory opened this issue Oct 26, 2020 · 4 comments · Fixed by #63904
Closed

Move name resolution cancellation test into Docker #43816

scalablecory opened this issue Oct 26, 2020 · 4 comments · Fixed by #63904
Labels
area-System.Net disabled-test The test is disabled in source code against the issue test-enhancement Improvements of test source code
Milestone

Comments

@scalablecory
Copy link
Contributor

#33420 introduces tests:

  • DnsGetHostAddresses_PostCancelledToken_Throws
  • DnsGetHostEntry_PostCancelledToken_Throws

These tests fail under a stressed CI environment as they depend on a cancellation token triggering before a DNS response comes back. To fix this, these tests might be moved into a Docker container with a non-working DNS server that will never respond.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Oct 26, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@scalablecory scalablecory added disabled-test The test is disabled in source code against the issue area-System.Net and removed untriaged New issue has not been triaged by the area owner labels Oct 26, 2020
@ghost
Copy link

ghost commented Oct 26, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@scalablecory scalablecory added this to the 6.0.0 milestone Oct 26, 2020
@scalablecory scalablecory changed the title Move name resolution test into Docker Move name resolution cancellation test into Docker Oct 26, 2020
@gfoidl
Copy link
Member

gfoidl commented Dec 18, 2020

Instead of

be moved into a Docker container with a non-working DNS server that will never respond

(which is quite some work), can we "flood" the dns-queue with lookup tasks and see if at least any of them will be canceled?
Something like gfoidl@2281e5e

Although "a non-working DNS server that will never respond" will be safer here in regard of the race, but there will be more moving parts that need to play together nicely.

@karelz karelz added the test-enhancement Improvements of test source code label Apr 23, 2021
@karelz karelz modified the milestones: 6.0.0, Future May 4, 2021
@antonfirsov
Copy link
Member

Sounds like something to address when together (or as a precondition of) fixing #63552. I think instead of expensive infrastructure refactoring we may just try serializing them as we did with many socket tests

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 17, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 21, 2022
@karelz karelz modified the milestones: Future, 7.0.0 Apr 8, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net disabled-test The test is disabled in source code against the issue test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants