Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build dotnet/runtime due to cmake error about MultiThreadedDebug #44152

Closed
stephentoub opened this issue Nov 2, 2020 · 11 comments · Fixed by #44155
Closed

Unable to build dotnet/runtime due to cmake error about MultiThreadedDebug #44152

stephentoub opened this issue Nov 2, 2020 · 11 comments · Fixed by #44155
Labels
untriaged New issue has not been triaged by the area owner

Comments

@stephentoub
Copy link
Member

stephentoub commented Nov 2, 2020

I'm unable to build dotnet/runtime after sync'ing and trying to do a clean build:

  CMake Error in D:/repos/runtime/src/libraries/Native/Unix/System.Globalization.Native/CMakeLists.txt:
    MSVC_RUNTIME_LIBRARY value 'MultiThreadedDebug' not known for this ASM_MASM
    compiler.

Note I'm building on Windows; I don't know why it's trying to process a unix cmakelists.

@jkoritzinsky, I assume this is due to #41897?

Do I need to somehow update my local configuration?

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Nov 2, 2020
@jkoritzinsky
Copy link
Member

Try cleaning your artifacts folder. In the meantime, I’ll investigate to see if I can repro locally.

@stephentoub
Copy link
Member Author

I've done a full git clean -xdf. No artifacts folder.

@jkoritzinsky
Copy link
Member

I'm looking now.

@jkoritzinsky
Copy link
Member

Which command are you using to build? (To make sure I'm checking the right execution sequence in CMake)

@jkoritzinsky
Copy link
Member

This looks like it was a bug in CMake that was fixed in 3.16.4. I'll put out a PR with the fix ASAP (since our minimum on Windows is 3.15.5 and our recommended version is 3.16.0+).

@jkoritzinsky
Copy link
Member

I have a fix in #44155. Can you pull down my PR and try building locally?

@stephentoub
Copy link
Member Author

Trying...

@stephentoub
Copy link
Member Author

Build is still going, but it's gotten past where it was failing before, so that's a good sign.

@jkoritzinsky
Copy link
Member

Once your build passes, I'm comfortable merging in #44155 before CI finishes to unblock people.

@stephentoub
Copy link
Member Author

It finished successfully. Thanks.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants