Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentNameMissingTerminator / DocumentDescriptionMissingTerminator Pkcs tests failing in CI on netfx #45168

Closed
stephentoub opened this issue Nov 24, 2020 · 5 comments · Fixed by #55837
Assignees
Labels
area-System.Security disabled-test The test is disabled in source code against the issue
Milestone

Comments

@stephentoub
Copy link
Member

https://dev.azure.com/dnceng/public/_build/results?buildId=898590&view=ms.vss-test-web.build-test-results-tab&runId=28705146&resultId=113241&paneView=debug

    System.Security.Cryptography.Pkcs.Tests.Pkcs9AttributeTests.DocumentNameMissingTerminator [FAIL]
      Assert.Equal() Failure
                        � (pos 8)
      Expected: My Name!
      Actual:   My Name!ns
                        � (pos 8)
      Stack Trace:
        /_/src/libraries/System.Security.Cryptography.Pkcs/tests/Pkcs9AttributeTests.cs(260,0): at System.Security.Cryptography.Pkcs.Tests.Pkcs9AttributeTests.DocumentNameMissingTerminator()
    System.Security.Cryptography.Pkcs.Tests.Pkcs9AttributeTests.DocumentDescriptionMissingTerminator [FAIL]
      Assert.Equal() Failure
                               � (pos 15)
      Expected: My Description!
      Actual:   My Description!???r
                               � (pos 15)
      Stack Trace:
        /_/src/libraries/System.Security.Cryptography.Pkcs/tests/Pkcs9AttributeTests.cs(187,0): at System.Security.Cryptography.Pkcs.Tests.Pkcs9AttributeTests.DocumentDescriptionMissingTerminator()

These tests were just added in 2e8c4c7 a few hours ago.
cc: @bartonjs

@stephentoub stephentoub added area-System.Security blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Nov 24, 2020
@stephentoub stephentoub added this to the 6.0.0 milestone Nov 24, 2020
@ghost
Copy link

ghost commented Nov 24, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley
See info in area-owners.md if you want to be subscribed.

Issue Details

https://dev.azure.com/dnceng/public/_build/results?buildId=898590&view=ms.vss-test-web.build-test-results-tab&runId=28705146&resultId=113241&paneView=debug

    System.Security.Cryptography.Pkcs.Tests.Pkcs9AttributeTests.DocumentNameMissingTerminator [FAIL]
      Assert.Equal() Failure
                        � (pos 8)
      Expected: My Name!
      Actual:   My Name!ns
                        � (pos 8)
      Stack Trace:
        /_/src/libraries/System.Security.Cryptography.Pkcs/tests/Pkcs9AttributeTests.cs(260,0): at System.Security.Cryptography.Pkcs.Tests.Pkcs9AttributeTests.DocumentNameMissingTerminator()
    System.Security.Cryptography.Pkcs.Tests.Pkcs9AttributeTests.DocumentDescriptionMissingTerminator [FAIL]
      Assert.Equal() Failure
                               � (pos 15)
      Expected: My Description!
      Actual:   My Description!???r
                               � (pos 15)
      Stack Trace:
        /_/src/libraries/System.Security.Cryptography.Pkcs/tests/Pkcs9AttributeTests.cs(187,0): at System.Security.Cryptography.Pkcs.Tests.Pkcs9AttributeTests.DocumentDescriptionMissingTerminator()

These tests were just added in 2e8c4c7 a few hours ago.
cc: @bartonjs

Author: stephentoub
Assignees: -
Labels:

area-System.Security, blocking-clean-ci

Milestone: 6.0.0

@safern
Copy link
Member

safern commented Nov 25, 2020

Issue is: https://github.com/dotnet/core-eng/issues/11507 -- @bartonjs can we disable the tests in the meantime?

@GrabYourPitchforks
Copy link
Member

Engineering services said it'll be a few days until the CI issue is resolved. Since we can't leave CI on the floor for that long, I've opened a PR to skip these tests on NetFx.

We should leave this issue open once that PR goes through. That way we can use this same issue to track re-enabling the tests once the CI issue is fully resolved.

@stephentoub stephentoub added disabled-test The test is disabled in source code against the issue and removed blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' untriaged New issue has not been triaged by the area owner labels Nov 25, 2020
@GrabYourPitchforks GrabYourPitchforks self-assigned this Nov 25, 2020
@GrabYourPitchforks
Copy link
Member

I'm assigning the issue to myself to track re-enabling the tests.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 16, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 16, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants