Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developers are directed to helpful documentation for existing obsoletions #47255

Closed
jeffhandley opened this issue Jan 21, 2021 · 1 comment · Fixed by #56690
Closed

Developers are directed to helpful documentation for existing obsoletions #47255

jeffhandley opened this issue Jan 21, 2021 · 1 comment · Fixed by #56690
Assignees
@jeffhandley
Labels
area-Meta
Milestone
6.0.0

Comments

@jeffhandley
Copy link
Member

jeffhandley commented Jan 21, 2021 •
edited
Loading

We have 114 [Obsolete] attributes that link to https://go.microsoft.com/fwlink/?linkid=14202, which is no longer relevant or helpful. The obsolete APIs should either link to relevant documentation topics or they should not have links embedded in their messages.

While updating these, we can consider using the new UrlFormat property that ObsoleteAttribute offers.

Per #56677:

AppDomain.SetDynamicBase and the methods at https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System/AppDomain.cs#L214:L235 are marked as [Obsolete] with a warning of the form AppDomain.Foo has been deprecated. Please investigate the use of AppDomainSetup.Bar instead. https://go.microsoft.com/fwlink/?linkid=14202, but the corresponding property of AppDomainSetup does not exist, confusing developers that stumble upon these obsolete methods.
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jan 21, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@jeffhandley jeffhandley self-assigned this Jan 21, 2021
@jeffhandley jeffhandley added this to the 6.0.0 milestone Jan 21, 2021
@jeffhandley jeffhandley removed the untriaged New issue has not been triaged by the area owner label Jan 21, 2021
This was referenced Jan 21, 2021
Closed
Merged
This was referenced Aug 1, 2021
Closed
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 1, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 4, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeffhandley jeffhandley

Labels
area-Meta
Projects
No open projects
Triage POD for Reflection, META, etc.
Status: Done
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Remove old fwlink from Obsolete messages and make message improvements
1 participant
@jeffhandley