Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac Catalyst: Need dllmap support #48110

Closed
rolfbjarne opened this issue Feb 10, 2021 · 6 comments
Closed

Mac Catalyst: Need dllmap support #48110

rolfbjarne opened this issue Feb 10, 2021 · 6 comments
Labels
area-AssemblyLoader-mono

Comments

@rolfbjarne
Copy link
Member

This is the same as #44242, just for Mac Catalyst, we need support for dllmaps.

Currently calling mono_dllmap_insert asserts:

    frame #8: 0x000000010004bd37 MyCatalystApp`mono_assertion_message_unreachable(file=<unavailable>, line=<unavailable>) at goutput.c:234:2 [opt]
    frame #9: 0x0000000100116255 MyCatalystApp`mono_dllmap_insert(assembly=<unavailable>, dll=<unavailable>, func=<unavailable>, tdll=<unavailable>, tfunc=<unavailable>) at native-library.c:278:2 [opt]

/cc @akoeplinger
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 10, 2021
@rolfbjarne rolfbjarne mentioned this issue Feb 10, 2021
Closed
61 tasks
@CoffeeFlux
Copy link
Contributor

CoffeeFlux commented Feb 10, 2021 •
edited
Loading

Any chance I can convince you to migrate to using PINVOKE_OVERRIDE instead? That way the code will work with both Mono and CoreCLR.

See xamarin/xamarin-macios#10504

@CoffeeFlux CoffeeFlux added area-AssemblyLoader-mono and removed untriaged New issue has not been triaged by the area owner labels Feb 10, 2021
@ghost
Copy link

ghost commented Feb 10, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

This is the same as #44242, just for Mac Catalyst, we need support for dllmaps.

Currently calling mono_dllmap_insert asserts:

    frame #8: 0x000000010004bd37 MyCatalystApp`mono_assertion_message_unreachable(file=<unavailable>, line=<unavailable>) at goutput.c:234:2 [opt]
    frame #9: 0x0000000100116255 MyCatalystApp`mono_dllmap_insert(assembly=<unavailable>, dll=<unavailable>, func=<unavailable>, tdll=<unavailable>, tfunc=<unavailable>) at native-library.c:278:2 [opt]

/cc @akoeplinger

Author: rolfbjarne
Assignees: -
Labels:

area-AssemblyLoader-mono
Milestone: -

@CoffeeFlux
Copy link
Contributor

This issue is also a variant of #43204

In both cases, using PINVOKE_OVERRIDE instead seems like the best solution.

@rolfbjarne
Copy link
Member Author

I can have a look and see if PINVOKE_OVERRIDE works for us.

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Mar 22, 2021
@rolfbjarne
[runtime] Redirect to our objc_msgSend wrapper functions when needed …
00c133b 
…for .NET code.

This makes the mono_dllmap_insert function unnecessary for .NET, so remove it.

Ref: dotnet/runtime#48110
Ref: dotnet/runtime#43204
Ref: xamarin#10504
@rolfbjarne rolfbjarne mentioned this issue Mar 22, 2021
Merged
rolfbjarne added a commit to xamarin/xamarin-macios that referenced this issue Mar 24, 2021
@rolfbjarne
[runtime] Redirect to our objc_msgSend wrapper functions when needed …
9153ede 
…for .NET code. (#10932)

This makes the mono_dllmap_insert function unnecessary for .NET, so remove it.

Ref: dotnet/runtime#48110
Ref: dotnet/runtime#43204
Ref: #10504
@rolfbjarne
Copy link
Member Author

Using PINVOKE_OVERRIDE seems to work, so I'm closing this.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-AssemblyLoader-mono
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rolfbjarne @CoffeeFlux