Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document wasm relinking functionality #48349

Open
2 tasks
CoffeeFlux opened this issue Feb 16, 2021 · 6 comments · Fixed by #49251
Open
2 tasks

Document wasm relinking functionality #48349

CoffeeFlux opened this issue Feb 16, 2021 · 6 comments · Fixed by #49251
Labels
arch-wasm WebAssembly architecture area-Build-mono documentation Documentation bug or enhancement, does not impact product or test code size-reduction Issues impacting final app size primary for size sensitive workloads
Milestone

Comments

@CoffeeFlux
Copy link
Contributor

CoffeeFlux commented Feb 16, 2021

Once #43689 is resolved we should be able to relink a project for even greater size reductions savings, most notably linking out ICU. We should document this and probably stand up a test.

  • public properties, items
  • default settings
@CoffeeFlux CoffeeFlux added documentation Documentation bug or enhancement, does not impact product or test code arch-wasm WebAssembly architecture area-Build-mono labels Feb 16, 2021
@CoffeeFlux CoffeeFlux added this to the 6.0.0 milestone Feb 16, 2021
@ghost
Copy link

ghost commented Feb 16, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Once #43689 is resolved we should be able to relink a project for even greater size reductions savings, most notably linking out ICU. We should document this and probably stand up a sample.

Author: CoffeeFlux
Assignees: -
Labels:

arch-wasm, area-Build-mono, documentation

Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 16, 2021
@CoffeeFlux CoffeeFlux removed the untriaged New issue has not been triaged by the area owner label Feb 16, 2021
@CoffeeFlux CoffeeFlux added the size-reduction Issues impacting final app size primary for size sensitive workloads label Feb 16, 2021
@ghost
Copy link

ghost commented Feb 16, 2021

Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar, @tannergooding, @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

Once #43689 is resolved we should be able to relink a project for even greater size reductions savings, most notably linking out ICU. We should document this and probably stand up a sample.

Author: CoffeeFlux
Assignees: -
Labels:

arch-wasm, area-Build-mono, documentation, size-reduction

Milestone: 6.0.0

@marek-safar
Copy link
Contributor

I don't think this should be only documented but automatically included in the release build config

@CoffeeFlux
Copy link
Contributor Author

CoffeeFlux commented Mar 2, 2021

Automatically including it seems nice from a size perspective but it would require fetching emscripten on customer machines, no? Either way, it would be really nice to get a successful ICU-less build on my machine for size estimation purposes sooner rather than later, whether that's accomplished through running it automatically or just documenting it.

@CoffeeFlux
Copy link
Contributor Author

Need to issue warning when emscripten is not present and use a system install by default.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 5, 2021
radical added a commit to radical/runtime that referenced this issue Mar 16, 2021
- But set to `false` if `$(PublishTrimmed)` is not true

Fixes: dotnet#48349
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 17, 2021
@radical radical reopened this Mar 17, 2021
@CoffeeFlux CoffeeFlux reopened this Mar 29, 2021
@lewing
Copy link
Member

lewing commented Sep 17, 2021

We should do a final review of the default configuration settings for this too.

@jeffhandley jeffhandley modified the milestones: 6.0.0, 6.0.x Nov 22, 2021
@akoeplinger akoeplinger removed this from the 6.0.x milestone Feb 12, 2024
@akoeplinger akoeplinger added this to the 9.0.0 milestone Feb 12, 2024
@lewing lewing assigned maraf and unassigned radical and steveisok Feb 21, 2024
@lewing lewing assigned mkhamoyan and unassigned maraf Apr 4, 2024
@lewing lewing modified the milestones: 9.0.0, 10.0.0 Jul 29, 2024
@mkhamoyan mkhamoyan removed their assignment Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Build-mono documentation Documentation bug or enhancement, does not impact product or test code size-reduction Issues impacting final app size primary for size sensitive workloads
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants