Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable AES GCM assert for decrypted bytes #48471

Closed
jkoritzinsky opened this issue Feb 18, 2021 · 1 comment · Fixed by #48728
Closed

Re-enable AES GCM assert for decrypted bytes #48471

jkoritzinsky opened this issue Feb 18, 2021 · 1 comment · Fixed by #48728
Labels
area-System.Security os-android untriaged New issue has not been triaged by the area owner
Milestone
6.0.0

Comments

@jkoritzinsky
Copy link
Member

In #48432, an assert was disabled because it caused a test suite to crash instead of failing gracefully on Android, which meant we couldn't get test results.

We should re-enable this assert once the issue causing the test to fail is fixed. See #48432 (comment)
@jkoritzinsky jkoritzinsky added this to the 6.0.0 milestone Feb 18, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 18, 2021
@ghost
Copy link

ghost commented Feb 18, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

In #48432, an assert was disabled because it caused a test suite to crash instead of failing gracefully on Android, which meant we couldn't get test results.

We should re-enable this assert once the issue causing the test to fail is fixed. See #48432 (comment)

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Security, os-android
Milestone: 6.0.0

@jkoritzinsky jkoritzinsky mentioned this issue Feb 18, 2021
Merged
jkoritzinsky added a commit to jkoritzinsky/runtime that referenced this issue Feb 18, 2021
@jkoritzinsky
Fix up Aes CCM/GCM support partially. Re-enable the length assert.
0a0fcb4 
Fixes dotnet#48471

This gets 49 more tests passing (split between Ccm and Gcm tests and sadly no full test suites).
@jkoritzinsky jkoritzinsky mentioned this issue Feb 24, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 24, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Security os-android untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fix up Aes CCM/GCM support jkoritzinsky/runtime
1 participant
@jkoritzinsky