-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source generator proposal: Equality #48733
Comments
Sorry for write here but ... is there a place for a join a discussion on allow edition in source generation and ideas to make the edition "save". I cant find it ... sorry again |
@Jose10go being able to modify existing code is not a feature we anticipate ever doing at this time. Please file a new issue on this repo if you want to discuss it. |
Moving this to the runtime repo, as this would be an in-box source generator. |
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
@danmoseley is the |
No, fixed. |
Assigning to myself to proceed with a WG to come up with a proposal here. TAgging @cston @333fred @RikkiGibson @jcouv who all showed interest in this topic. Related to dotnet/roslyn#48646. |
We should consider building and shipping a source generator for equality as part of the default .NET tooling. The C# LDT has explicitly backed off from doing a completely-customizable equality feature: https://github.com/dotnet/csharplang/blob/master/meetings/2020/LDM-2020-03-30.md#value-equality. However, it seems like customizable equality (such as sequence equality for collections, case-insensitive comparison for strings, other customizations) are and will continue to be a pain point. We should consider building a first-party generator for equality, with annotation types built into the framework and the generator shipped with the SDK. If we don't do this with the initial release of source-generators or soon afterwards, we may end up with a fractured ecosystem of such generators with no consistent style.
/cc @chsienki
The text was updated successfully, but these errors were encountered: