-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QUIC] CI doesn't run the tests #49138
Comments
Tagging subscribers to this area: @dotnet/ncl Issue DetailsATM, we depend on Insider Preview version of Windows, see https://github.com/dotnet/runtimelab/tree/feature/System.Net.Experimental.MsQuic#usage. Figure out how to enable them. Figure out how to enable them for Linux and MacOS as well (probably depends on open questions around OpenSSL). cc: @CarnaViire @wfurt @scalablecory
|
Triage: @ViktorHofer @safern we think this might be solvable if we have our csproj test files download a msquic lib on Linux -- does this seem reasonable? Can you help us with the changes? This would only be temporary until we figure out how we want to package msquic. |
Before we enable in CI, we should fix tests to run locally. |
Would this be the same for al distros? Where are you going to download the lib into? Do we want to it be dynamic (downloaded before every run if needed) or should we have that as a machine requirement? |
we will need separate binaries for musl based distros like Alpine. Rest should work fine. msquic project has CI but I don't know if they produce consumable binaries. |
FYI we got the Helix Windows.10.Amd64.ClientPre.VS2019.Pre queue set up with windows insiders builds. It's currently updating ~monthly. This queue can only be used on internal azdo builds so we have a nightly job that runs it. Is there a specific minimum windows build version required? |
Before attempting any intermediate steps, why not figure out how to package msquic first? If the msquic repo provides a nuget package, the lib can be consumed easily. |
It does not but it possibly can even if that is just transient package. On Windows, all needed bits will be part of .NET runtime. The alternative is to pull in msquic code and make that part of runtime build. I think that is what @safern help us to do for the runtime lab experiment. |
Would that create a source dependency just for testing or also for the product? Preferably we would not build the msquic repo as part of our build. |
We will need to solve it somehow for the product as well. cc: @dleeapho @NikolaMilosavljevic @nibanks I'm not sure of this is best way how to track the product changes but it seems related and we have all the right minds here now. I personally feel the same way @ViktorHofer but we will need to find a way how to bundle it to the product. |
Agreed. Let's have the product related discussion here as well. Distributing msquic as part of the runtime pack is actually quite easy. We could either bring it along as a dependency of one of the runtime libs (which assembly exactly has a dependency on it?) or directly reference it in the runtime pack shared framework package. Either way, we need a nuget package or multiple nuget packages (RID based) to consume msquic in dotnet/runtime. |
So, is the ask (or at least line of thought) that MsQuic produce a NuGet package that .NET would consume on Windows. (FYI @ThadHouse) |
We run the tests on a docker image for Linux, for Windows we have an opened issue with infra to provide us with new enough Win images. The rest of the packaging tasks is tracked here #55639. Closing in favor of that. |
ATM, we depend on Insider Preview version of Windows, see https://github.com/dotnet/runtimelab/tree/feature/System.Net.Experimental.MsQuic#usage.
For that reason, we are not running any QUIC tests in CI pipelines.
Figure out how to enable them. Figure out how to enable them for Linux and MacOS as well (probably depends on open questions around OpenSSL).
cc: @CarnaViire @wfurt @scalablecory
The text was updated successfully, but these errors were encountered: