Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure System.Security.Cryptography.X509Certificates.Tests.DynamicChainTests.BuildInvalidSignatureTwice(endEntityErrors: NotTimeValid | NotSignatureValid, intermediateErrors: NoError, rootErrors: UntrustedRoot) #49984

Closed
VincentBu opened this issue Mar 22, 2021 · 4 comments
Labels
arch-arm64 area-System.Security JitStress CLR JIT issues involving JIT internal stress modes os-windows untriaged New issue has not been triaged by the area owner

Comments

@VincentBu
Copy link
Contributor

Run: runtime-coreclr libraries-jitstressregs 20210321.1

Failed test:

net6.0-windows-Release-arm64-CoreCLR_checked-jitstressregs3-Windows.10.Arm64v8.Open
 -System.Security.Cryptography.X509Certificates.Tests.DynamicChainTests.BuildInvalidSignatureTwice(endEntityErrors: NotTimeValid | NotSignatureValid, intermediateErrors: NoError, rootErrors: UntrustedRoot)

Error message:

Assert.Equal() Failure
Expected: NotTimeValid | NotSignatureValid | UntrustedRoot
Actual:   NotSignatureValid | UntrustedRoot


Stack trace
   at System.Security.Cryptography.X509Certificates.Tests.DynamicChainTests.<BuildInvalidSignatureTwice>g__CheckChain|7_2(<>c__DisplayClass7_0& , <>c__DisplayClass7_1& , <>c__DisplayClass7_2& ) in /_/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs:line 194
   at System.Security.Cryptography.X509Certificates.Tests.DynamicChainTests.BuildInvalidSignatureTwice(X509ChainStatusFlags endEntityErrors, X509ChainStatusFlags intermediateErrors, X509ChainStatusFlags rootErrors) in /_/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs:line 211
@VincentBu VincentBu added arch-arm64 area-System.Security os-windows JitStress CLR JIT issues involving JIT internal stress modes labels Mar 22, 2021
@ghost
Copy link

ghost commented Mar 22, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime-coreclr libraries-jitstressregs 20210321.1

Failed test:

net6.0-windows-Release-arm64-CoreCLR_checked-jitstressregs3-Windows.10.Arm64v8.Open
 -System.Security.Cryptography.X509Certificates.Tests.DynamicChainTests.BuildInvalidSignatureTwice(endEntityErrors: NotTimeValid | NotSignatureValid, intermediateErrors: NoError, rootErrors: UntrustedRoot)

Error message:

Assert.Equal() Failure
Expected: NotTimeValid | NotSignatureValid | UntrustedRoot
Actual:   NotSignatureValid | UntrustedRoot


Stack trace
   at System.Security.Cryptography.X509Certificates.Tests.DynamicChainTests.<BuildInvalidSignatureTwice>g__CheckChain|7_2(<>c__DisplayClass7_0& , <>c__DisplayClass7_1& , <>c__DisplayClass7_2& ) in /_/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs:line 194
   at System.Security.Cryptography.X509Certificates.Tests.DynamicChainTests.BuildInvalidSignatureTwice(X509ChainStatusFlags endEntityErrors, X509ChainStatusFlags intermediateErrors, X509ChainStatusFlags rootErrors) in /_/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs:line 211
Author: VincentBu
Assignees: -
Labels:

JitStress, arch-arm64, area-System.Security, os-windows

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 22, 2021
@vcsjones
Copy link
Member

vcsjones commented Mar 22, 2021

Looks like a dup of #48851.

Never mind, not a dupe. Two tests are named BuildInvalidSignatureTwice.

@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Mar 22, 2021
@vcsjones
Copy link
Member

Hmm. My hypothesis is the chain builder is confused which intermediate it should be using since the test chain builder is not making certificate chains with unique names per-test. It may have been using the "wrong" intermediate, but since the test is expecting an invalid signature, worked most of the time anyway.

@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Mar 22, 2021
@bartonjs
Copy link
Member

bartonjs commented Jul 2, 2021

I don't see any failures for the DynamicChainTests version since #50048 got merged. So calling this one closed.

@bartonjs bartonjs closed this as completed Jul 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 area-System.Security JitStress CLR JIT issues involving JIT internal stress modes os-windows untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

3 participants